Content-Type: multipart/alternative;
 boundary="------------llmyGohC41tsb3BgRpL6SIeV"
Message-ID: <d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru>
Date: Tue, 14 Jan 2025 22:29:59 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAAKRu_bn7wXa2pwrD-1EOM=dZOW9oNj+cgpALrtzc4k-YbwXJA@mail.gmail.com>
 <202501141821.eiduwdflzxuf@alvherre.pgsql>
 <CAAKRu_b0U_DDFSYP9JNo=GXbHyyGohDgvLj6wkYDsrZxtyg6VA@mail.gmail.com>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: 
 <CAAKRu_b0U_DDFSYP9JNo=GXbHyyGohDgvLj6wkYDsrZxtyg6VA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/d58df4a0-1dbd-4e59-8f41-c0be5877f3a7%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------llmyGohC41tsb3BgRpL6SIeV
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 14.01.2025 22:01, Melanie Plageman wrote:
> On Tue, Jan 14, 2025 at 1:21 PM Alvaro Herrera<alvherre@alvh.no-ip.org>  wrote:
>> On 2025-Jan-13, Melanie Plageman wrote:
>>
>>> I've gone with VACUUM_AUTOVACUUM, VACUUM_COST_DELAY, and
>>> VACUUM_FREEZING, but I am open to feedback.
>> Looks good to me.  I checked these two queries, whose results appear
>> correct:
>>
>> 55432 18devel 560655=# select name, category from pg_settings where category ilike '%vacuum%';
>>                   name                  │              category
>> ───────────────────────────────────────┼─────────────────────────────────────
>>   autovacuum                            │ Vacuuming / Automatic Vacuuming
>>   autovacuum_analyze_scale_factor       │ Vacuuming / Automatic Vacuuming
>>   autovacuum_analyze_threshold          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_freeze_max_age             │ Vacuuming / Automatic Vacuuming
>>   autovacuum_max_workers                │ Vacuuming / Automatic Vacuuming
>>   autovacuum_multixact_freeze_max_age   │ Vacuuming / Automatic Vacuuming
>>   autovacuum_naptime                    │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_cost_delay          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_cost_limit          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_insert_scale_factor │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_insert_threshold    │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_scale_factor        │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_threshold           │ Vacuuming / Automatic Vacuuming
>>   autovacuum_worker_slots               │ Vacuuming / Automatic Vacuuming
>>   vacuum_cost_delay                     │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_limit                     │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_dirty                │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_hit                  │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_miss                 │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_failsafe_age                   │ Vacuuming / Freezing
>>   vacuum_freeze_min_age                 │ Vacuuming / Freezing
>>   vacuum_freeze_table_age               │ Vacuuming / Freezing
>>   vacuum_multixact_failsafe_age         │ Vacuuming / Freezing
>>   vacuum_multixact_freeze_min_age       │ Vacuuming / Freezing
>>   vacuum_multixact_freeze_table_age     │ Vacuuming / Freezing
>>
>>
>> 55432 18devel 560655=# select name, category from pg_settings where (short_desc ilike '%vacuum%' or extra_desc ilike '%vacuum%') and category not ilike '%vacuum%';
>>              name             │              category
>> ─────────────────────────────┼─────────────────────────────────────
>>   autovacuum_work_mem         │ Resource Usage / Memory
>>   log_autovacuum_min_duration │ Reporting and Logging / What to Log
>>   maintenance_work_mem        │ Resource Usage / Memory
>>   vacuum_buffer_usage_limit   │ Resource Usage / Memory
> Yea, Alena also mentioned these GUCs that are in different groups. I
> think it is okay for these four to remain in their current locations
> as their current groupings seem descriptive enough.
>
Looking at them, I am willing to agree with you

-- 
Regards,
Alena Rybakina
Postgres Professional

--------------llmyGohC41tsb3BgRpL6SIeV
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 14.01.2025 22:01, Melanie Plageman
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAAKRu_b0U_DDFSYP9JNo=GXbHyyGohDgvLj6wkYDsrZxtyg6VA@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">On Tue, Jan 14, 2025 at 1:21 PM Alvaro Herrera <a class="moz-txt-link-rfc2396E" href="mailto:alvherre@alvh.no-ip.org">&lt;alvherre@alvh.no-ip.org&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">
On 2025-Jan-13, Melanie Plageman wrote:

</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">I've gone with VACUUM_AUTOVACUUM, VACUUM_COST_DELAY, and
VACUUM_FREEZING, but I am open to feedback.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
Looks good to me.  I checked these two queries, whose results appear
correct:

55432 18devel 560655=# select name, category from pg_settings where category ilike '%vacuum%';
                 name                  │              category
───────────────────────────────────────┼─────────────────────────────────────
 autovacuum                            │ Vacuuming / Automatic Vacuuming
 autovacuum_analyze_scale_factor       │ Vacuuming / Automatic Vacuuming
 autovacuum_analyze_threshold          │ Vacuuming / Automatic Vacuuming
 autovacuum_freeze_max_age             │ Vacuuming / Automatic Vacuuming
 autovacuum_max_workers                │ Vacuuming / Automatic Vacuuming
 autovacuum_multixact_freeze_max_age   │ Vacuuming / Automatic Vacuuming
 autovacuum_naptime                    │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_cost_delay          │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_cost_limit          │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_insert_scale_factor │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_insert_threshold    │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_scale_factor        │ Vacuuming / Automatic Vacuuming
 autovacuum_vacuum_threshold           │ Vacuuming / Automatic Vacuuming
 autovacuum_worker_slots               │ Vacuuming / Automatic Vacuuming
 vacuum_cost_delay                     │ Vacuuming / Cost-Based Vacuum Delay
 vacuum_cost_limit                     │ Vacuuming / Cost-Based Vacuum Delay
 vacuum_cost_page_dirty                │ Vacuuming / Cost-Based Vacuum Delay
 vacuum_cost_page_hit                  │ Vacuuming / Cost-Based Vacuum Delay
 vacuum_cost_page_miss                 │ Vacuuming / Cost-Based Vacuum Delay
 vacuum_failsafe_age                   │ Vacuuming / Freezing
 vacuum_freeze_min_age                 │ Vacuuming / Freezing
 vacuum_freeze_table_age               │ Vacuuming / Freezing
 vacuum_multixact_failsafe_age         │ Vacuuming / Freezing
 vacuum_multixact_freeze_min_age       │ Vacuuming / Freezing
 vacuum_multixact_freeze_table_age     │ Vacuuming / Freezing


55432 18devel 560655=# select name, category from pg_settings where (short_desc ilike '%vacuum%' or extra_desc ilike '%vacuum%') and category not ilike '%vacuum%';
            name             │              category
─────────────────────────────┼─────────────────────────────────────
 autovacuum_work_mem         │ Resource Usage / Memory
 log_autovacuum_min_duration │ Reporting and Logging / What to Log
 maintenance_work_mem        │ Resource Usage / Memory
 vacuum_buffer_usage_limit   │ Resource Usage / Memory
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Yea, Alena also mentioned these GUCs that are in different groups. I
think it is okay for these four to remain in their current locations
as their current groupings seem descriptive enough.

</pre>
    </blockquote>
    <p>Looking at them, I am willing to agree with you<span
      style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
  </body>
</html>

--------------llmyGohC41tsb3BgRpL6SIeV--