Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s2Qxn-002whE-Ph for pgsql-committers@arkaria.postgresql.org; Thu, 02 May 2024 07:34:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s2Qxl-00GSOK-Cb for pgsql-committers@arkaria.postgresql.org; Thu, 02 May 2024 07:34:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s2Qxl-00GSOB-53 for pgsql-committers@lists.postgresql.org; Thu, 02 May 2024 07:34:42 +0000 Received: from fout4-smtp.messagingengine.com ([103.168.172.147]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s2Qxi-0018So-NE for pgsql-committers@lists.postgresql.org; Thu, 02 May 2024 07:34:41 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 0200C1380361; Thu, 2 May 2024 03:34:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 02 May 2024 03:34:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714635276; x=1714721676; bh=dvFe0FZBHz23ekEfxol2H1ojkGtmLJqLtJA08y/tX78=; b= pvrtZoOGhhPkwmnh/nkIf5ZGtKjwbL3zEDUALyfqv3DCLp5PY1jh9XUjkq5SE5Rh ljs4YeUlG4Z+mAfHvh0Nbvi5QvKTB1VbW8kdujfWp0ZOeVPaMq16NGTTsxsyp6j6 4/LiVw/K1TfeD+cCNsgdPv5T/CJ8uJ47N51+XNtJ1TCN4WoVpjbWcDP8/EOtvznp jZnbm2ywTBIR10JOq7ZzGjPA+cBad9f4dTtKXhLLIE557xgnUHxomw3InRO2su31 U5QPm5/CpbS1VeJs/BpCcsyd/UWY4ET7KVSqw+CfAJMElW8eBZIgsPbsctDgVhle NWOpBbSA1KYLvvMPfKO5Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714635276; x= 1714721676; bh=dvFe0FZBHz23ekEfxol2H1ojkGtmLJqLtJA08y/tX78=; b=a /WXcYbvsqNgIv5btbCqsNRWDG1T5MfAKEpyKcidc78gEcdi1gDZJ7eG+1MgTaLh4 c6IuLYMlErKCDogFeHWOvt+f5gWHNs8Eb4/zPrBghgRMfCN+NkOERVXPpVLFUjYt hK1jFyFAX/yZjMXwaKp+hsVPrWrWI3Nn9x1NsIEUR/kSGPZUXsZ8jmF+DjNWtDKi E722AnTVdH7kVYJHwgGyCHS+IvqF4mLCYq2Br5xsdnMRjhhAmnatYqJGPAg7e6HV BgJFcqB5+KqDPNycyLlGvuJNng9aNrAlf0NGGyi5AZU1RySWxCgSsCOjx4sQlMmu I/OCm3QSW9jomiBB0tB9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddujedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepheeivdfhuefhueeggfefheegjedtveeuhfethfeufedv udfgtdeuhefgfeduhfffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 May 2024 03:34:36 -0400 (EDT) Message-ID: Date: Thu, 2 May 2024 09:34:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Support C.UTF-8 locale in the new builtin collation provider. To: Jeff Davis , pgsql-committers@lists.postgresql.org References: Content-Language: en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 19.03.24 23:29, Jeff Davis wrote: > Support C.UTF-8 locale in the new builtin collation provider. This commit changed the functions builtin_locale_encoding() and builtin_validate_locale() in pg_locale.c, but did not update the comments that claim that "C" is the only supported locale name. (I think it would be best to remove the comment altogether and let the code speak for itself.)