From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Add hooks for session start and session end
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@postgresql.org
References: <E1eEzZG-0001kP-KI@gemulon.postgresql.org>
 <10176.1510764611@sss.pgh.pa.us>
 <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net>
 <21509.1510772165@sss.pgh.pa.us>
 <762a0864-a831-1009-c2c7-297695d1e3e4@2ndQuadrant.com>
 <6a231271-671f-a5b0-e4ba-a0ae57ba50cd@2ndQuadrant.com>
 <5681.1510781444@sss.pgh.pa.us>
 <74fc9ffd-ded3-6139-dd51-440fc15fb1ac@2ndQuadrant.com>
 <CAB7nPqTQQm0vs+BqXv+QRqUPhjPAYihb9NQwOrHG8dxvjMzhpg@mail.gmail.com>
Message-ID: <df4b9777-c357-f68d-c6db-3f391671369b@2ndQuadrant.com>
Date: Wed, 15 Nov 2017 20:26:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: 
 <CAB7nPqTQQm0vs+BqXv+QRqUPhjPAYihb9NQwOrHG8dxvjMzhpg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk


On 11/15/2017 05:07 PM, Michael Paquier wrote:
> On Thu, Nov 16, 2017 at 6:53 AM, Andrew Dunstan
> <andrew.dunstan@2ndquadrant.com> wrote:
>> On 11/15/2017 04:30 PM, Tom Lane wrote:
>>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>>> On 11/15/2017 02:17 PM, Andrew Dunstan wrote:
>>>>> Yeah, that was my first instinct. But then how do the test_rls_hooks
>>>>> tests succeed? They too have a shared_preload_library.
>>>> Aha, it does
>>>>     LOAD 'test_rls_hooks';
>>>> at the start of its script. Of course we can't do that here.
>>>> Not sure what the best way to resolve this is. For now I'm inclined just
>>>> to override the installcheck target in the module's makefile and disable
>>>> it in vcregress.pl.
>>> Yeah.
>>>
>>>> Maybe we need to shift from installcheck to check mode for these
>>>> modules. That would involve a buildfarm script change.
>>> Seems like expending an awful lot of cycles in support of a rather trivial
>>> feature.
>> Possibly. At any rate I'm not going to do it immediately.
> So why not just nuking it from the core code? The test module is
> basically dead code now, and has been useful during review to check
> that the positions of the hooks are adapted to run SQL queries at
> session start and end. I don't mind to include it in my own set of
> plugins on github instead.


It's not dead at all. "make check" works just fine. It would be possible
to create a trivial buildfarm module to run that if we wanted to.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services