Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKdJv-0007qD-JU for pgsql-committers@arkaria.postgresql.org; Tue, 13 Jun 2017 04:20:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dKdJt-0007Ng-UM for pgsql-committers@arkaria.postgresql.org; Tue, 13 Jun 2017 04:20:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dKdJt-0007NG-C6 for pgsql-committers@postgresql.org; Tue, 13 Jun 2017 04:20:45 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKdJo-00010Q-6w for pgsql-committers@postgresql.org; Tue, 13 Jun 2017 04:20:44 +0000 Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v5D4KXND018026; Tue, 13 Jun 2017 13:20:33 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id BCA165F63F; Tue, 13 Jun 2017 13:20:33 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id B033B5F592; Tue, 13 Jun 2017 13:20:33 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id AA0AE40055A; Tue, 13 Jun 2017 13:20:33 +0900 (JST) Subject: Re: pgsql: Apply RLS policies to partitioned tables. References: <10974.1497227727@sss.pgh.pa.us> <0c5b8b18-262d-de09-50e1-6cf4815d74ab@joeconway.com> <25990.1497235885@sss.pgh.pa.us> <89e6ae66-96ee-b6eb-7195-d88dbb988f2f@lab.ntt.co.jp> <7444.1497275164@sss.pgh.pa.us> From: Amit Langote Message-ID: Date: Tue, 13 Jun 2017 13:20:15 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <7444.1497275164@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Tom Lane Cc: Joe Conway , pgsql-committers@postgresql.org X-TM-AS-MML: disable List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 2017/06/12 22:46, Tom Lane wrote: > Amit Langote writes: >> How about something like the attached? The patch makes >> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on >> WithCheckOption.qual that is being initialized for each partition. > > Well, the question then is whether that behaves correctly. Where it would > matter is if the WCO qual contains a SubPlan, because you'd be adding > multiple instances of the subplan to the PlanState's list. I think it's > probably all right, but it might be wise to add a test case where there > is such a subplan. > > Spacing and comment wording seem a bit random in this, too. Was about to send the updated patch, but noticed that you already committed it after adding the test. Thanks a lot. Regards, Amit -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers