Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUplr-0006pX-P4 for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 13:34:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oUplo-0001dF-TH for pgsql-committers@arkaria.postgresql.org; Sun, 04 Sep 2022 13:34:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUplo-0001d4-M6 for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 13:34:40 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUplj-0001ki-3K for pgsql-committers@lists.postgresql.org; Sun, 04 Sep 2022 13:34:39 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 522F620008; Sun, 4 Sep 2022 13:34:29 +0000 (UTC) Message-ID: Date: Sun, 4 Sep 2022 09:34:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Build all Flex files standalone Content-Language: en-US To: John Naylor , John Naylor Cc: pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-09-04 Su 02:19, John Naylor wrote: > Crake fails with > > headerscheck: > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2: > Sep 04 01:56:01 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gram.h: No such file or directory > Sep 04 01:56:01 26 | #include "jsonpath_gram.h" > Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~ > Sep 04 01:56:01 compilation terminated. > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1 > cpluspluscheck: > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3: > Sep 04 01:57:19 > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: > fatal error: jsonpath_gram.h: No such file or directory > Sep 04 01:57:19 26 | #include "jsonpath_gram.h" > Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~ > > I don't get the same in an already-built tree. I also don't see an > exception for gramparse.h, which I imagine would have the same issue? Probably happens because crake does vpath builds. I think you're going to have to set up EXTRAINCLUDES for it - see near the bottom of the headerscheck script. Possibly something like     src/backend/utils/adt/*)     EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;; cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com