Content-Type: multipart/alternative;
 boundary="------------4uJb03451GpcpGg5YzxcBZeK"
Message-ID: <e51357f4-4ac5-4b64-b01a-15931485702f@dunslane.net>
Date: Sun, 15 Sep 2024 16:33:49 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@lists.postgresql.org
References: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
 <66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net>
 <ZudAtNRQOkveAa91@momjian.us>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <ZudAtNRQOkveAa91@momjian.us>
Archived-At: 
 <https://www.postgresql.org/message-id/e51357f4-4ac5-4b64-b01a-15931485702f%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------4uJb03451GpcpGg5YzxcBZeK
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024-09-15 Su 4:16 PM, Bruce Momjian wrote:
> On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote:
>>
>> On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote:
>>
>>      Perl scripts:  eliminate "Useless interpolation" warnings
>>
>>      Eliminate warnings of Perl Critic from src/tools.
>>
>>      Backpatch-through: master
>>
>>
>>
>> I don't understand this commit. The buildfarm members crake and koel regularly
>> run the perl critic checks and have not complained. See for example from before
>> this change:<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm= 
>> koel&dt=2024-09-15%2003%3A34%3A02&stg=perl-check>
>>
>> The change doesn't seem to have had any discussion either. This particular
>> warning is surely a very low level (i.e. fairly unimportant) one, of the type
>> we normally ignore. If some version of perlcritic has raised it to severity 5
>> then the correct action IMNSHO would be to add an exception for it to the
>> perlcriticrc, like we do for ProhibitLeadingZeros. If not, then perhaps you can
>> explain how you got the warnings.
> So, the warning is about the use of double-quotes when single-quotes
> will work just fine.  I wrote a new script and changed it to single
> quotes, so for consistency, I looked at other Perl scripts that might
> have the issue.  The message I got was:
>
>     /root/add_commit_links.pl: Useless interpolation of literal string at line 51 near 'my $tmpfile = $file . ".tmp";'.  (Severity: 1)
>
> My $HOME/.perlcritic has:
>
> 	severity = 1
>
> and that is why I saw it.  Is it a bad change?


I understand perfectly what the warning is about.

But the project's perlcritic policy is expressed at 
src/tools/perlcheck/perlcriticrc. It's basically severity 5 plus some 
additions and one exception. We shouldn't be imposing our personal 
perlcritic policies on the project.

The change isn't bad in itself, but there shouldn't be any expectation 
that we will keep to this policy, as it's not required by project policy.

There is a huge mass of perlcritic issues in our perl code at severity 1 
(over 13000 by my count). If we're going to clean them up (which I would 
oppose) we should do it in a systematic way. It's hard to see why this 
one is special.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------4uJb03451GpcpGg5YzxcBZeK
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2024-09-15 Su 4:16 PM, Bruce Momjian
      wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:ZudAtNRQOkveAa91@momjian.us">
      <pre class="moz-quote-pre" wrap="">On Sun, Sep 15, 2024 at 02:30:47PM -0400, Andrew Dunstan wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">

On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote:

    Perl scripts:  eliminate "Useless interpolation" warnings

    Eliminate warnings of Perl Critic from src/tools.

    Backpatch-through: master


I don't understand this commit. The buildfarm members crake and koel regularly
run the perl critic checks and have not complained. See for example from before
this change: <a class="moz-txt-link-rfc2396E" href="https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koel&amp;dt=2024-09-15%2003%3A34%3A02&amp;stg=perl-check">&lt;https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=
koel&amp;dt=2024-09-15%2003%3A34%3A02&amp;stg=perl-check&gt;</a>

The change doesn't seem to have had any discussion either. This particular
warning is surely a very low level (i.e. fairly unimportant) one, of the type
we normally ignore. If some version of perlcritic has raised it to severity 5
then the correct action IMNSHO would be to add an exception for it to the
perlcriticrc, like we do for ProhibitLeadingZeros. If not, then perhaps you can
explain how you got the warnings.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
So, the warning is about the use of double-quotes when single-quotes
will work just fine.  I wrote a new script and changed it to single
quotes, so for consistency, I looked at other Perl scripts that might
have the issue.  The message I got was:

   /root/add_commit_links.pl: Useless interpolation of literal string at line 51 near 'my $tmpfile = $file . ".tmp";'.  (Severity: 1)

My $HOME/.perlcritic has:

	severity = 1

and that is why I saw it.  Is it a bad change?</pre>
    </blockquote>
    <p><br>
    </p>
    <p>I understand perfectly what the warning is about.<br>
    </p>
    <p><span style="white-space: pre-wrap">But the project's perlcritic policy is expressed at src/tools/perlcheck/perlcriticrc. It's basically severity 5 plus some additions and one exception. We shouldn't be imposing our personal perlcritic policies on the project. </span></p>
    <p><span style="white-space: pre-wrap">The change isn't bad in itself, but there shouldn't be any expectation that we will keep to this policy, as it's not required by project policy.</span></p>
    <p><span style="white-space: pre-wrap">There is a huge mass of perlcritic issues in our perl code at severity 1 (over 13000 by my count). If we're going to clean them up (which I would oppose) we should do it in a systematic way. It's hard to see why this one is special.</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <p><span style="white-space: pre-wrap">cheers</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <p><span style="white-space: pre-wrap">andrew
</span></p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------4uJb03451GpcpGg5YzxcBZeK--