Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vGESS-00AXnH-Ln for pgsql-committers@arkaria.postgresql.org; Tue, 04 Nov 2025 10:40:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vGESR-00Cufk-Jq for pgsql-committers@arkaria.postgresql.org; Tue, 04 Nov 2025 10:40:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vGESQ-00CufZ-Ul for pgsql-committers@lists.postgresql.org; Tue, 04 Nov 2025 10:40:10 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vGESN-005uof-0u for pgsql-committers@lists.postgresql.org; Tue, 04 Nov 2025 10:40:09 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 6FC581D00320; Tue, 4 Nov 2025 05:40:05 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 04 Nov 2025 05:40:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1762252805; x=1762339205; bh=nn1sqnI0EEQum4D1sZdj6Yc9XU31IKOLTn4KZYdYpwI=; b= qpxrleM4IiDOtnJKqljLpfjUd0SkcpGZTp5rlpN26/selsTPxi6C1S32r4aXv3AZ YSy/Z5CuCXEfhBz/mXGRVy7SGVubRscMF68KM+p9RNjh+K3zlpzx73sKvzwBXmrA Ldly7WrpgRhgwhepjnsXTkE2a3reAmhSPFdV/eul3839M6IiFX7Q51fxQXCU3jn7 i2KzLtvgCM+/qdguFKc9XcxOS8kIwGJ5gvsNAnyN1eWwUzgU7WJMRJukPpnj4LCr y02DTsVijpGldXJvlbmN2n38iwoUHP0CJsCo7YYb7q+A1Of38zXQjkyBlvf7fIae t+llf37c42fQPo+KhQT5EQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1762252805; x=1762339205; bh=n n1sqnI0EEQum4D1sZdj6Yc9XU31IKOLTn4KZYdYpwI=; b=Na6cgcnbFd4itpiHu x67nngwYx88Ek3anWUUOuwfwpNdXDgd6g8yUXRrpq6HVs+n/IdOVZNK+AShkkFzk TTENLq2o/x2t3s5rduxFMTc6zY3IatldWYpcqWABuZWqvPEu8kBeNCuciesiCPJI u/44mPe4caimCAjnL7iMUFgBdSZVVHHUKRBnG1NFksc8xlhQncpkoY1fedvLmnrq uKrQEZ05MZio1D3kV8l8+Orm20iEzTJ+nnUUjDkPAO66kdPdMUfXjnCPZKZ6FK0a OZqOR3EB3rIjDzzmRCkTL646dUfT693fI3oU4HGfDJIgc4NZwsu93POwTgYuRC8e C2jMg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddukedtkedtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertd dtvdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegv ihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepudfgjefffeelfedvge dvjedvieehvefghfejgfduhfevvdejveefheetlefgveefnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruh htrdhorhhgpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgdprhgtphhtthhopehpghhsqh hlqdgtohhmmhhithhtvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Nov 2025 05:40:04 -0500 (EST) Message-ID: Date: Tue, 4 Nov 2025 11:40:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing To: =?UTF-8?Q?=C3=81lvaro_Herrera?= , pgsql-committers@lists.postgresql.org References: Content-Language: de-DE, en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 31.10.25 18:08, Álvaro Herrera wrote: > pg_createsubscriber: Fix error complaining about the wrong thing > > The code updates the system identifier, then runs pg_walreset; if the > latter fails, it complains about the former, which makes no sense. > Change the error message to complain about the right thing. - pg_log_info("subscriber successfully changed the system identifier"); + pg_log_info("subscriber successfully reset WAL on the subscriber"); Maybe that message has one "subscriber" too many?