Message-ID: <e852442da35b4f31acc600ed98bbee0f12e65e0c.camel@j-davis.com>
Subject: Re: pgsql: pg_upgrade: Fix inconsistency in memory freeing
From: Jeff Davis <pgsql@j-davis.com>
To: Michael Paquier <michael@paquier.xyz>,
	pgsql-committers@lists.postgresql.org
Date: Sat, 29 Mar 2025 09:24:58 -0700
In-Reply-To: <E1tnozS-000424-2y@gemulon.postgresql.org>
References: <E1tnozS-000424-2y@gemulon.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/e852442da35b4f31acc600ed98bbee0f12e65e0c.camel%40j-davis.com>
Precedence: bulk

On Fri, 2025-02-28 at 01:16 +0000, Michael Paquier wrote:
> pg_upgrade: Fix inconsistency in memory freeing

> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2a083ab807db6d9e2e0e3aa82ee8f6ff=
9fc44c8d
>=20

This seems to have broken the pg_upgrade test when olddump/oldinstall
are set to PG14 or earlier:

stderr:
#   Failed test 'check that locales in new cluster match original
cluster'
#   at
/home/jdavis/git/postgresql/src/bin/pg_upgrade/t/002_pg_upgrade.pl line
506.
#          got: '0|c|C|C|NULL'
#     expected: '0|c|C|C|'
# Looks like you failed 1 test of 16.

Looking at the commit, it seems you are escaping NULL as a literal.=20

Regards,
	Jeff Davis