Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYl2f-002abL-82 for pgsql-committers@arkaria.postgresql.org; Wed, 23 Aug 2023 10:24:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qYl2e-00BhQN-0G for pgsql-committers@arkaria.postgresql.org; Wed, 23 Aug 2023 10:24:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYl2d-00BhPw-Oe for pgsql-committers@lists.postgresql.org; Wed, 23 Aug 2023 10:24:47 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYl2b-000YDw-5V for pgsql-committers@lists.postgresql.org; Wed, 23 Aug 2023 10:24:46 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 01EAB5C00AB; Wed, 23 Aug 2023 06:24:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 23 Aug 2023 06:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1692786282; x=1692872682; bh=WSaROSHXjc+kNufNOEk/YBPjLZxVFTXXvj6 tHqOoTIA=; b=JVg6uUzZ4SpNBVTOSvucu3a5UKKrqzyCWRLkHoihfhB8jvTuSPO oNebH/Vwx5tj1SJJNNnN/OGzFOO9XOZH6btVgMoGMzMXxIPVngm6DXhxaLiyjlEi V7g0ITr8we4Pr/pv3oUW+4vP2bthSBy1Ct8Oxyl0rF3DTjzOZ2+sYI6CfDv09B2q EDZpRpPNcUioqpntwcEmapLMt8CTRxpgfu/YgXSeUgHlzaHKhia0MKuBcgykx3Nc pC9oBu/LjS2f1S5h4i/+WCOBsnxJvN7/m6XaOUmu5Q1jr2VenFWu8vnF/sK1pQ1Z vR90IDgfIu/nRxNxcWS2FNPiAUUABD5GN9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1692786282; x= 1692872682; bh=WSaROSHXjc+kNufNOEk/YBPjLZxVFTXXvj6tHqOoTIA=; b=l 9u5Xfcf9r1LZuK3LGdrjOkMWvbobO8beZuzpOjvsF2UOGPzST3xDlP4ihsWFrkK3 PTAAGMuAnrykYohVd8EN0sCt/mRE5Kg8fZ2KLThxi+8Pkq5WboKQZiR496wpatdW j/UnPdLV7z1//NQ3BHqlUyFQ4uvMlJEzvJnjW1eQvWt+Gk6A5iT6C4oXDEkqZvp3 GPKt76vtivj64LAxgt95ky7wz6mBBJcWs9AXNLPcF/7W96z2+mEtG6yoiJ15sfaG Guapvhvd229QIwsugiCtYRLVidjWb6nqgAiOLW+GDvtbrtHFG55U74fRRenkWzji t7m+QPn+Lz0UOK5xbHxNA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvgedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgqe enucggtffrrghtthgvrhhnpedugfduudehhfejieeuudfhieffveeghffggffhgfffgfdu vefhleejieejhfduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Aug 2023 06:24:42 -0400 (EDT) Message-ID: Date: Wed, 23 Aug 2023 12:24:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog. Content-Language: en-US To: Jeff Davis , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 22.08.23 22:08, Jeff Davis wrote: > Fix pg_dump assertion failure when dumping pg_catalog. > > Commit 396d348b04 did not account for the default collation. > > Also, use pg_log_warning() instead of Assert(). Looking at this: pg_log_warning("invalid collation \"%s\"", qcollname); qcollname is already a quoted identifier, so this message would be doubly quoted. Maybe you should use collinfo->dobj.name in the messages. Also, for pg_fatal("unrecognized collation provider '%c'", collprovider[0]); use double quotes.