Feedback-ID: ie0a040ee:Fastmail
Message-ID: <eba0f4a4-bfac-4d03-873f-ed3f07fa06a3@eisentraut.org>
Date: Sat, 30 Dec 2023 00:33:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Make all Perl warnings fatal
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Korotkov <aekorotkov@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>, pgsql-committers@lists.postgresql.org
References: <E1rJGvp-00CWH1-Lj@gemulon.postgresql.org>
 <c2c4a65f9598b05b95d36e5025391892f8408eba.camel@j-davis.com>
 <CAPpHfdv31WnqELu6ZxE6fS-TqtQMAqLA9AWbK3=CvQBokLj_-A@mail.gmail.com>
 <3261739.1703889716@sss.pgh.pa.us>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <3261739.1703889716@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/eba0f4a4-bfac-4d03-873f-ed3f07fa06a3%40eisentraut.org>
Precedence: bulk

On 29.12.23 23:41, Tom Lane wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
>> On Fri, Dec 29, 2023 at 10:13 PM Jeff Davis <pgsql@j-davis.com> wrote:
>>> This seems to be causing problems in the buildfarm:
>>> Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
>>> (m//) at t/001_mutated_bindpasswd.pl line 23.
> 
>> It seems to cause failures for many buildfarm machines.
> 
> Presumably, exactly the ones that don't set PG_TEST_EXTRA :-(.
> Peter would not have noticed this if he keeps that set in his
> test environment.
> 
> The fix looks simple enough, although a bit tedious because there
> are a bunch of places to change.  I can have a go at it if no-one
> else is already on it?

I was already on it.  It looks like it's okay now.