Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfN3v-0004m3-BK for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Oct 2021 14:04:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfN3u-0000hl-3p for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Oct 2021 14:04:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfN3t-0000ha-EG for pgsql-hackers@lists.postgresql.org; Tue, 26 Oct 2021 14:04:21 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mfN3k-0007XB-Fi for pgsql-hackers@lists.postgresql.org; Tue, 26 Oct 2021 14:04:20 +0000 Received: by mail-ed1-x534.google.com with SMTP id w12so8433213edd.11 for ; Tue, 26 Oct 2021 07:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=7NMH21AwHS7crG+fIH1LA6ygPkPKzKbIzJ6bpnRxCKk=; b=SFdBYx+H4VXe17o/dDnyUthrac8MEyIh0duj629wGH5qZYI0X3d8K1INSR37/5Y2f2 UJONmwIzF35xmwNceO+AjSqC9V31nUd4ck3LIMhU/uY3fsuugJCkEef1tvaIISSRcRxU MqX9gmfxgpKlrl+cOK+anK7n9Oo0peLY4V2oMpepDyD3FEzBrslJs7IGrOOuyj4R2+Mc Y00yAJTQy7tTR6D75Y/DVjYROAYm5nrnc4dvRl4Mz6iNbAyZmmiMsBXoR4tfinbMaDXn R1dnU8jS5OVpBPfDOvDjYUj+0kCGPnu0NTowFjiWjE4BHuawUoas23BxKa6knxjv8DdJ acCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7NMH21AwHS7crG+fIH1LA6ygPkPKzKbIzJ6bpnRxCKk=; b=SjbGOM29kU4pDbCpjsiOHcXLHarMg01MvHLc1Zx6Kd5clz69UU/1oapPsBaFA64EkM zxIOAYxb1Cm7tySknuSCJFMSP4OxTANx9w/GNpl1xv2+JLPI3q0AXjfdQc+LqXVRSxgz /q9LJTpRwylbZFde9YS4Ic8vMtuIvQFBkhKBvh6t72xMxZaDcPSS4O7fW1KgqEYPsVUA 9YOErm0FL7+l85DmLwOhULw2EKtsyRBBjbA2+lGtnue3EhEKOtqrBquP3F4KukFhq7mC 9/2pg8nAqKTX+3rbeokv3qc953fHSxQQV6aqtxbSqktvJjKqRqX8DZQx67wzHnyPVhf1 6nQg== X-Gm-Message-State: AOAM532MMLZPDglRTCIoWqOnmcgNcZiZ4K7qwXwdj0wZkh4jtQWlM5Vs YbepfXSPAb/OJ57HmJ+NIlOMp92KYfZYWGZI5tVshjhAUX9Z2oCVoH00e28hAznMnTc5GyBngL+ T2/I362nwvEA0LRR5mtjf9YyEOp60B/Cna//tWm3scP4oRAgUFKZ33DB4rXeWRqurWYVd72xbpE GB4c6MIw9MWSABE3dlP9RXI6LjXTJIdKAqC7oED1pDz5/VzY6umg2XWos0aA/smKh852E/2fvza vpbeQBDpnfmq5FCATmhGcWi4GMgbCGsS3StYqIJKQFe89C0a2zLEss= X-Google-Smtp-Source: ABdhPJyEcjsqEjK4EQW7QG8+LEbP1legAQBPNM0W+LPzqNb2svUXeMVZqQZIOSjqK/BI83GuJQ7pvw== X-Received: by 2002:a17:907:2d12:: with SMTP id gs18mr30117891ejc.353.1635256943986; Tue, 26 Oct 2021 07:02:23 -0700 (PDT) Received: from [10.80.18.190] ([145.40.212.39]) by smtp.gmail.com with ESMTPSA id d22sm9476669ejj.47.2021.10.26.07.02.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 07:02:23 -0700 (PDT) Subject: Re: pgsql: Remove unused wait events. To: pgsql-hackers@lists.postgresql.org References: <4047667.1635179918@sss.pgh.pa.us> <4050629.1635182306@sss.pgh.pa.us> From: Markus Wanner Message-ID: Date: Tue, 26 Oct 2021 16:02:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 26.10.21 04:20, Amit Kapila wrote: > I agree with the points raised here and will revert this for v14. Thanks, Amit. I appreciate the revert. Note that the removed events were almost at the end of WaitEventIO enum, except for one last entry: WAIT_EVENT_WAL_WRITE. Just as a data point: Our BDR extension indeed references the wait events in question (or at least it used to do so up until that commit). -- Markus Wanner EDB: http://www.enterprisedb.com