Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc5a6-0007nR-8T for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 14:24:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pc5a5-0007AO-3b for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Mar 2023 14:24:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pc5a4-0007AF-Pd for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 14:24:48 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pc5a1-0001Zk-MH for pgsql-hackers@lists.postgresql.org; Tue, 14 Mar 2023 14:24:47 +0000 Received: by mail-ed1-x52b.google.com with SMTP id eh3so6857755edb.11 for ; Tue, 14 Mar 2023 07:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1678803884; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Casy82F9d70J1KTg9AR26GR+DxDhYLhlI8OcFmdNvE8=; b=V3gseq2ev8hKsfd1LVzyIJ6tvnQ1jnNfHO958WP/mrT7tT343OuuZRckQZyXZWlNuX lUvLGb2fqJ0Ei7r3GYNBPu6Xlz/klhO/QtLKCYZ2b4Aoe45ZR1wIepiHULrwLj46LRve 93DnYNJ0OrsYZdjHbej2hN1oCUIZYFImWIz/JnBb3Y+SIzTI5PiLyrVI7xWZT/ck7oE4 AD9CE9Vhjt1iVHX7yx0fbmhZGi/HINUB0qIVgKOhSiXx8LatExEFdSWw5zUFIhAv9N5c ieese6hD+RlgLYWIAf5d/tbDaLy5EzozaWm4KbR2WuYBSE/R0iZ2eL1MnCbTnq0tPYAt zSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678803884; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Casy82F9d70J1KTg9AR26GR+DxDhYLhlI8OcFmdNvE8=; b=x/2beeuczjajsyAq4bSH9NrIl35JUUmqg7ZY5M1VHDMw8l2m8DOIuNs2KhKs7fauco Rcv858RX+NewiK4hFnm0FMxI8n3yJOthqtiqH1EOfyyz20xOMGHPKl33KuEsgyI/ajZF KoL2iGK6vjhkN5mau32eja+45F61/exF9qumr3dI4Rc2xouOrbkWXbvRgF0rVOO1AegZ MsqXcDI3jaFDNBOefxrUXEobqW+eeKjIrOIVkCl/9J+rUQ5d49v3DZ4nECuYlJnhM1lz 3q8ySGhvzSpgolycgOaCMVAF06o4Vxgnhrl5WQ9BZN1W8cbtJRoFyFbMC+/Rktdefn+K 1gYA== X-Gm-Message-State: AO0yUKWnFKbmbzvFQfmV2ma9Q6KdYbtjb+DsocXFRCrM6zwJ9BJPJOZu 0O1pQAzO8LLpiUlR4s4+H9Al7DreCU3yfohCVFCGq5o9SYvhNbmGqhjg1pgW2mLg2A8EwY7eZx6 12MhQBn9wM8a0oJi7X9Fs+ObFidBBjr6iQMzly2m9Dxs8vxkVIKmpAX8R5S0uQ6Db32RJfICFSk djwyoRy4jhwwwBwU0QH/dJQOD7lR48wKmISwtHgGt/a+Q4eUhUkGlo X-Google-Smtp-Source: AK7set+1yZzFIr/lMVMiFhcW6CbYky18EXzqGK10/EnUKlc4yieZgwOlcnqE8GFb4+2i4eg6Bq8i1A== X-Received: by 2002:a17:907:1118:b0:8b1:7ab0:a462 with SMTP id qu24-20020a170907111800b008b17ab0a462mr2358044ejb.7.1678803883999; Tue, 14 Mar 2023 07:24:43 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-228-162.bb.vodafone.cz. [86.49.228.162]) by smtp.gmail.com with ESMTPSA id x62-20020a50bac4000000b004fbd365fb33sm1127562ede.38.2023.03.14.07.24.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 07:24:43 -0700 (PDT) Message-ID: Date: Tue, 14 Mar 2023 15:24:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) Content-Language: en-US To: Christoph Berg Cc: Michael Paquier , Daniel Gustafsson , Tomas Vondra , PostgreSQL Hackers References: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com> <74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/14/23 11:34, Christoph Berg wrote: > Re: Tomas Vondra >> and I don't think there's a good place to inject the 'rm' so I ended up >> adding a 'cleanup_cmd' right after 'compress_cmd'. But it seems a bit >> strange / hacky. Maybe there's a better way? > > Does the file need to be removed at all? Could we leave it there and > have "make clean" remove it? > I don't think that'd work, because of the automatic "discovery" where we check if a file exists, and if not we try to append .gz and .lz4. So if you leave the .toc, we'd not find the .lz4, making the test useless ... regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company