Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qMyyg-003lVy-Ka for pgsql-committers@arkaria.postgresql.org; Fri, 21 Jul 2023 22:52:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qMyyf-009l2E-4m for pgsql-committers@arkaria.postgresql.org; Fri, 21 Jul 2023 22:52:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qMyye-009l25-Tr for pgsql-committers@lists.postgresql.org; Fri, 21 Jul 2023 22:52:00 +0000 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qMyyb-000l7S-6T for pgsql-committers@lists.postgresql.org; Fri, 21 Jul 2023 22:51:59 +0000 Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-76c64da0e46so105942239f.0 for ; Fri, 21 Jul 2023 15:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20221208.gappssmtp.com; s=20221208; t=1689979916; x=1690584716; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=jVNw2/dRXmKS83r9o/u+1QuZF5cfOtXsxc/YAcC/ZT4=; b=UTqFzjhy7REzEveFH5WBm3zqzI6AOdFdsO6w1D+1InNypMYRZj4e9CmLOi3Dwmekxu d1cyIRmY63hdpJA6ZAIp82vvNEBnqYSVTk0PKRwZ0wGLAXWQs6IaoeFv7lPF3lRAhi4D 9JhhUcX7wGyRsojbBBz8IdNQ/wu6GbzB3xAE0RvFf5xpW7qyKuLtLodpXM/aviPM4J+C s/c6rSdi6VpgmKi3xfBZ3PaOCgP7pX8NaZGAoYdAV8lEtHZsCEkarCyNVLXEHfqA0EOZ JKpdxa3o04qdZ7ArIefYk9rMPdpJibHyXs548BiT60z8wtkrCKZeHPowHzpgo730TIOm oSAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689979916; x=1690584716; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jVNw2/dRXmKS83r9o/u+1QuZF5cfOtXsxc/YAcC/ZT4=; b=U93DxZAT5Q/+FPVH62WUvFK41IV/0nAclGWIqASWXevVamMvO4N2x4AJmOftcMSfIt kqEc/JPY7saRsXP/MtwpbxGtVS95L8pejHiqaxNy5JKUnnQ7RWpkuaQkTS/0FsANosS8 XWqML+DycA/mDwqic+SzQ2r70hBCwXhRVFM0A8AihTWUKj7qgd236d8tcbJuqxxXey3P jc3GWbWeX3uMFJE3XiRlDBKvkmw7nTKMYEIxn8PO+gNuKkwr/n6vNOaF2lTuhI20xXV5 a7pP2ko/IXFo26xh32mtPgY0sgjVtqZVLZs5AP9Jx0XbXRTwcne6Dwnnm7YGHP4To9nQ bt6w== X-Gm-Message-State: ABy/qLYXyOh8MbCvCUZDW1b+d/K7zLnlhR3eCIdxoT7v0/xCBZxf/vUs yJdrEslaj0Ll/PQqwQ8Ze4UU+A== X-Google-Smtp-Source: APBJJlHWJ8HDpVGr8Rp2SiW3GFJ8Rei/61AHqds7VFABGD0oFyBceth/LFyQGDrGJehZYkNVM3YCWg== X-Received: by 2002:a6b:d814:0:b0:787:167e:f796 with SMTP id y20-20020a6bd814000000b00787167ef796mr1135164iob.15.1689979916363; Fri, 21 Jul 2023 15:51:56 -0700 (PDT) Received: from jeff-laptop.lan (c-73-170-46-202.hsd1.ca.comcast.net. [73.170.46.202]) by smtp.gmail.com with ESMTPSA id fe21-20020a056a002f1500b00668652b020bsm3447665pfb.105.2023.07.21.15.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 15:51:55 -0700 (PDT) Message-ID: Subject: Re: pgsql: Fix calculation of relid sets for partitionwise child joins. From: Jeff Davis To: Tom Lane , pgsql-committers@lists.postgresql.org Date: Fri, 21 Jul 2023 15:51:54 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 2023-07-21 at 16:00 +0000, Tom Lane wrote: > Fix calculation of relid sets for partitionwise child joins. In CI, I'm seeing a compiler warning here: https://cirrus-ci.com/task/6112262960709632 [22:28:11.772] joinrels.c: In function =E2=80=98try_partitionwise_join=E2= =80=99: [22:28:11.772] joinrels.c:1546:11: error: variable =E2=80=98child_joinrelid= s=E2=80=99 set but not used [-Werror=3Dunused-but-set-variable] [22:28:11.772] 1546 | Relids child_joinrelids; [22:28:11.772] | ^~~~~~~~~~~~~~~~ [22:28:11.772] cc1: all warnings being treated as errors Regards, Jeff Davis