Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncR5e-0003vJ-7O for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 12:18:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncR5b-0006rA-RC for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 12:18:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncR5b-0006r1-IZ for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 12:18:15 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncR5Y-0006i0-77 for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 12:18:14 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id B5BC724000D; Thu, 7 Apr 2022 12:18:07 +0000 (UTC) Message-ID: Date: Thu, 7 Apr 2022 08:18:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Prefetch data referenced by the WAL, take II. Content-Language: en-US To: Andres Freund , Thomas Munro Cc: pgsql-committers@lists.postgresql.org References: <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 4/7/22 04:36, Andres Freund wrote: > Hi, > > On 2022-04-07 07:44:20 +0000, Thomas Munro wrote: >> Prefetch data referenced by the WAL, take II. > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-04-07%2008%3A17%3A27 > thinks that xlogpretcher.h doesn't include enough... > > I had added those checks to CI, but apparently somehow screwed that up. > > Or maybe it's the scripts that are screwed up? Because I don't see any error > checking in headerscheck/cpluspluscheck. And indeed, locally they show the > errors, but exit with 0. Yeah, you can't rely on the exit status, if they produce output that should be regarded as a failure (that's what crake does). cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com