Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1n9y-0002ww-3I for pgsql-hackers@arkaria.postgresql.org; Wed, 24 May 2023 12:00:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q1n8w-0007Vb-Jv for pgsql-hackers@arkaria.postgresql.org; Wed, 24 May 2023 11:59:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1n8w-0007VR-8x for pgsql-hackers@lists.postgresql.org; Wed, 24 May 2023 11:59:02 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q1n8t-001dQR-Hk for pgsql-hackers@postgresql.org; Wed, 24 May 2023 11:59:01 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f607dc98cdso7526035e9.1 for ; Wed, 24 May 2023 04:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684929537; x=1687521537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y1j548cTAP9d6mlW6iwC1rYgKOx/f/zB1UCSEKZpRII=; b=F4L2zlwqC8vbZQ/ej0veDYvMUmrJ4XoJ8ITqs50VUNvttle/fcqsjrEQRTOkr+99ms tuygmWOCdzn/pp2w65OQTmHX1B3UqLt4kjRcgccDoZCZeC2ZDVREm8d8xzlfWzd2etUG pl1qUG9hUdOVozzv6YYpTNEWkYpyUrg4agxKCWypT/tcLsmIlXKgLvXgFPfAlmKPtCnx 7YLgCwuLTf0EdKIAA7SXPCI6gDRCUi7EMASWo0GqVexxWMGv3SOMppaVwPX1pBoT2eZQ 75c9M61J0bAPwkAT0LE+XB5RupH60T3NJ5CLH3Fs7/eAI9PuL5yNjT3TUP6jgLXjx04p p/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684929537; x=1687521537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y1j548cTAP9d6mlW6iwC1rYgKOx/f/zB1UCSEKZpRII=; b=KR4KPSFydLsxYbK0X0+/2DmhlBjRioGquosuM1NlsFzK0YziAMznMCOT20C2gMzgyQ HjESnL7WQ5YNJMFcHOmYEuETOB3ax7Ym9oiypWXKABtswirj0WQgGWKIdQG2IN7hddfs kpDs5vpHYEb+YeFOyLLs/a8yPDiLcaV6xuGewrKU8PwqFpGx9YEsr4NnnyNNgbdQVpea ANlWfMR6Hd74hlZPFeq4C8sM6NNQycXBP9XGOFR/TDsR87NnRkiYqEwr9K/YbeqXAfOs 2/zNjIKRYj+wB2JNbbUetSGLyPF/Jc+RDXCvlft5LlioJE0QwKF6YPaX4y0lK78r7jiB B4og== X-Gm-Message-State: AC+VfDxld6+j4vjkPLvC69ofOacc7kfkLj/yBLlqogD2Q/9yIwEFroci GWwF6dac2uy0veqF01dBJ2M66aj9UDqgWw== X-Google-Smtp-Source: ACHHUZ7Hn0ISVOR6j3slzYFOAn7CXH2CPqN0JRAUTsHm3TDZoZwV9LABnl0IiTRlzpwNnan9mFg2gg== X-Received: by 2002:a05:600c:2148:b0:3f4:26d4:91b0 with SMTP id v8-20020a05600c214800b003f426d491b0mr10509558wml.40.1684929537257; Wed, 24 May 2023 04:58:57 -0700 (PDT) Received: from [192.168.14.23] (54-240-197-232.amazon.com. [54.240.197.232]) by smtp.gmail.com with ESMTPSA id y6-20020a05600c364600b003f420667807sm2114220wmq.11.2023.05.24.04.58.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 04:58:56 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 13:58:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: pgsql: TAP test for logical decoding on standby To: Robert Haas , Andres Freund Cc: "pgsql-hackers@postgresql.org" References: Content-Language: en-US From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 5/23/23 5:15 PM, Robert Haas wrote: > On Sat, Apr 8, 2023 at 5:26 AM Andres Freund wrote: >> TAP test for logical decoding on standby > > Small nitpicks: > > 1. The test names generated by check_slots_conflicting_status() start > with a capital letter, while most other test names start with a > lower-case letter. > Yeah, not sure that would deserve a fix for its own but if we address 2. then let's do 1. too. > 2. The function is called 7 times, 6 with a true argument and 1 with a > false argument, but the test name only depends on whether the argument > is true or false, so we get the same test name 6 times. Maybe there's > not a reasonable way to do better, I'm not sure, but it's not ideal. > I agree that's not ideal (but one could still figure out which one is failing if any by looking at the perl script). If we want to "improve" this, what about passing a second argument that would provide more context in the test name? Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com