Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w0r7V-002GVV-2G for pgsql-committers@arkaria.postgresql.org; Fri, 13 Mar 2026 01:15:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w0r7U-0016bu-09 for pgsql-committers@arkaria.postgresql.org; Fri, 13 Mar 2026 01:15:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w0r7T-0016bm-2i for pgsql-committers@lists.postgresql.org; Fri, 13 Mar 2026 01:15:16 +0000 Received: from mail-dy1-x132a.google.com ([2607:f8b0:4864:20::132a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w0r7R-00000002O0j-3jkU for pgsql-committers@lists.postgresql.org; Fri, 13 Mar 2026 01:15:16 +0000 Received: by mail-dy1-x132a.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso2084478eec.1 for ; Thu, 12 Mar 2026 18:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1773364512; x=1773969312; darn=lists.postgresql.org; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dSEVDG382j7i2krWqPYh4bEQIVk34Fh6p3bKFEx/DAc=; b=gP6jZ8w6+ivIzAZ+Wv6KqGFAHcPljb1iEiiy6fshLtyM7yY/1+DUkwKPbLu2AayrQM +xLzQfkenqSRTfdcLjpSgZQJJlD5R7MHaTOIaMKJvXwYfp7eUMi1BUIvGFcCX5xtGNPV n04Y/1vChkr+jIedQXNGPKfHDhbFvPRShV9NwgjWkTPaPkBZ0Cnoq3wm2TK1sjznd2bp Qs8kNYBgAP/TY7LF+wXkMhlL75OVCUu6gTiGiFc8Rh91j2UoUWkAJkO+mp5HIBwOtmDn n6iSziWau0ZKgo7dPepWEH5NjsuRqkYrui2Ly9dBG+5N3w5kmak59dSq8HwwCWY+mghm dVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773364512; x=1773969312; h=mime-version:user-agent:references:in-reply-to:date:cc:to:from :subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dSEVDG382j7i2krWqPYh4bEQIVk34Fh6p3bKFEx/DAc=; b=Jyy2eNcQ1Fgs1JzVb4ImYeG4br5jyx9YbORNimdpfnNHjmZ9sFz6VKyHKrqTT2BO6w +/LRMUmldPYF+Go2HK7v8BjOOJ7l4YzLbrdxUTnVPqRKhSj3EPu7ExmGrTB/IkuBOPaj x4zpF3rc6iDLDWntJx0XQeJ4t14eXY7s72cXKy4Z1sp+rS7Dbt0leMcH04UbyXD1/1JD MGcpc9mQuZFJzVmQUVdWsyOtPwlaQ5ZvVEePrMLmLhNkes/oWYEbIRDztnhS4Yv7A0/7 +YBkXSE6RhsCgfBx43gdxzqYtEWXI11VDvoJ3k8eaTrrkFOBTASLh01cGiZy5Sy0WwZA fW7A== X-Forwarded-Encrypted: i=1; AJvYcCWMU7XvLcoXYm415QlUWKbA7gJ/hoaSC7sZl65GwVbA4x4Yhleq+r2RYu/EJixZLTFe87qmpHhk9DlHnw3B2Dl3@lists.postgresql.org X-Gm-Message-State: AOJu0YwTyGPkNFKQLOX0/mB5Kq8oKz6xi86B8uX7e/BZHbIGDS+LDeFP qlWPjIXepTIkjqHPiIkt2rdA9aGXeoE0jtmohRSAaveqgH+3RZ45On6uxz0f5V2mzHzqNuLAlHi 4lrhI02oh X-Gm-Gg: ATEYQzwLv41S216EkfcMeTDhEfU1mvnaf3HaTlTlcMdSxMUQswoo6dFvVw2bKrYRS4I u6K2W135nHmnLn5XvV5+IVi0ztRft1FMXYHF/MZOqTm5fZ7m/4yh7LWNgOLBuCuQ+l/mrxYhZtM QnCelG4ZdH1h26qoOuiD0/yqYXghLYlnCT4nI5KrH2DoNRjB5O2Cnqy3PwmEGy7rpGYPKzLxDhE k2PzFPS6D3jRRZTEz7QF/2erZk7Vct6X+p/KxA0ZfQd1lKmLhMH2akqpmpyE7OChmPaKoV8Dkfc IKQGWEmBH5CHIPACli/oURELVxirIcbq8cWYPwz0XD9888MglZ2gZvtApsb95PpFyZV0Kbx+Czw 9NhNr0zXaY2qmn2/Esr//vgV8+gKpAVRDH61uSGbRZaZeWz6IgK4p0p5ZKteKAYG9ZcEZuaQ7Tu i7k7+uLJU6+v0mOOfbE1lYJcQkD/e5ap8/lxoGjTk1whtQxDwEgFc= X-Received: by 2002:a05:7300:730e:b0:2be:2a1a:f62 with SMTP id 5a478bee46e88-2bea5582194mr724066eec.34.1773364511870; Thu, 12 Mar 2026 18:15:11 -0700 (PDT) Received: from jeff-laptop.lan (c-24-7-19-3.hsd1.ca.comcast.net. [24.7.19.3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2beab52702asm571407eec.16.2026.03.12.18.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 18:15:10 -0700 (PDT) Message-ID: Subject: Re: pgsql: CREATE SUBSCRIPTION ... SERVER. From: Jeff Davis To: Andres Freund , Peter Eisentraut Cc: Jeff Davis , pgsql-committers@lists.postgresql.org Date: Thu, 12 Mar 2026 18:15:09 -0700 In-Reply-To: <03d52b80fd264bb683fb2c46ad7a2934cb656f1a.camel@j-davis.com> References: <1bb21c7d-885f-4f07-a3ed-21b60d7c92c6@eisentraut.org> <03d52b80fd264bb683fb2c46ad7a2934cb656f1a.camel@j-davis.com> Content-Type: multipart/mixed; boundary="=-mbNK+jemjYYLziKlyr4o" User-Agent: Evolution 3.52.3-0ubuntu1.1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=-mbNK+jemjYYLziKlyr4o Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2026-03-11 at 17:59 -0700, Jeff Davis wrote: > That leaves some awkwardness, but I don't immediately see a cleaner > way > to do it. Suggestions welcome. I did see a way to avoid the volatile entirely, it just needs a redundant MemoryContextSwtichTo(). I think this is cleaner overall, attached. Regards, Jeff Davis --=-mbNK+jemjYYLziKlyr4o Content-Disposition: attachment; filename="v21-0001-Clean-up-PG_TRY-PG_FINALLY.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="v21-0001-Clean-up-PG_TRY-PG_FINALLY.patch"; charset="UTF-8" RnJvbSBhZTNiZWI4NDkzODg4ZTFmZjhjMjM4MTNiYjU2ZTRhYmM0ZThiNzIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIERhdmlzIDxqZWZmQGotZGF2aXMuY29tPgpEYXRlOiBU aHUsIDEyIE1hciAyMDI2IDE4OjA0OjM1IC0wNzAwClN1YmplY3Q6IFtQQVRDSCB2MjFdIENsZWFu IHVwIFBHX1RSWSgpL1BHX0ZJTkFMTFkoKS4KCkluIEZvcmVpZ25TZXJ2ZXJDb25uZWN0aW9uU3Ry aW5nKCksIHJlZmFjdG9yIHRoZSBQR19UUlkoKS9QR19GSU5BTExZKCkKYmxvY2tzIHRvIGF2b2lk IHRoZSBuZWVkIGZvciB2b2xhdGlsZSBhdCBhbGwuIFRoZSBvbmx5IGRvd25zaWRlIGlzIGEKcmVk dW5kYW50IE1lbW9yeUNvbnRleHRTd2l0Y2hUbygpIGluIHRoZSBzdWNjZXNzIGNhc2UuCgpSZXBv cnRlZC1ieTogQW5kcmVzIEZyZXVuZCA8YW5kcmVzQGFuYXJhemVsLmRlPgpEaXNjdXNzaW9uOiBo dHRwczovL3Bvc3Rnci5lcy9tL3h2ZGpyZHFucGFwM3VxN293YmFveDNyN3A1Z2Y3c3Y2MmFhcWYy anUzdmI2eWdsYXRyQGt2dndob3Vkcmx4cQotLS0KIHNyYy9iYWNrZW5kL2ZvcmVpZ24vZm9yZWln bi5jIHwgOSArKysrKy0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvZm9yZWlnbi9mb3JlaWduLmMgYi9z cmMvYmFja2VuZC9mb3JlaWduL2ZvcmVpZ24uYwppbmRleCAxNjBjZjZmNTFjOS4uY2YxMGE4YzAw ZjkgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2ZvcmVpZ24vZm9yZWlnbi5jCisrKyBiL3NyYy9i YWNrZW5kL2ZvcmVpZ24vZm9yZWlnbi5jCkBAIC0yMjUsNyArMjI1LDYgQEAgRm9yZWlnblNlcnZl ckNvbm5lY3Rpb25TdHJpbmcoT2lkIHVzZXJpZCwgT2lkIHNlcnZlcmlkKQogewogCU1lbW9yeUNv bnRleHQgdGVtcENvbnRleHQ7CiAJTWVtb3J5Q29udGV4dCBvbGRjeHQ7Ci0JdGV4dAkgICAqdm9s YXRpbGUgY29ubmVjdGlvbl90ZXh0ID0gTlVMTDsKIAljaGFyCSAgICpyZXN1bHQgPSBOVUxMOwog CiAJLyoKQEAgLTI0Myw2ICsyNDIsNyBAQCBGb3JlaWduU2VydmVyQ29ubmVjdGlvblN0cmluZyhP aWQgdXNlcmlkLCBPaWQgc2VydmVyaWQpCiAJewogCQlGb3JlaWduU2VydmVyICpzZXJ2ZXI7CiAJ CUZvcmVpZ25EYXRhV3JhcHBlciAqZmR3OworCQl0ZXh0CSAgICpjb25uZWN0aW9uX3RleHQgPSBO VUxMOwogCQlEYXR1bQkJY29ubmVjdGlvbl9kYXR1bTsKIAogCQlzZXJ2ZXIgPSBHZXRGb3JlaWdu U2VydmVyKHNlcnZlcmlkKTsKQEAgLTI2MiwxNCArMjYyLDE1IEBAIEZvcmVpZ25TZXJ2ZXJDb25u ZWN0aW9uU3RyaW5nKE9pZCB1c2VyaWQsIE9pZCBzZXJ2ZXJpZCkKIAkJCQkJCQkJCQkJUG9pbnRl ckdldERhdHVtKE5VTEwpKTsKIAogCQljb25uZWN0aW9uX3RleHQgPSBEYXR1bUdldFRleHRQUChj b25uZWN0aW9uX2RhdHVtKTsKKworCQlNZW1vcnlDb250ZXh0U3dpdGNoVG8ob2xkY3h0KTsKKwkJ cmVzdWx0ID0gdGV4dF90b19jc3RyaW5nKCh0ZXh0ICopIGNvbm5lY3Rpb25fdGV4dCk7CiAJfQog CVBHX0ZJTkFMTFkoKTsKIAl7CisJCS8qIG5vLW9wIG9uIHN1Y2Nlc3MgcGF0aCAqLwogCQlNZW1v cnlDb250ZXh0U3dpdGNoVG8ob2xkY3h0KTsKIAotCQlpZiAoY29ubmVjdGlvbl90ZXh0KQotCQkJ cmVzdWx0ID0gdGV4dF90b19jc3RyaW5nKCh0ZXh0ICopIGNvbm5lY3Rpb25fdGV4dCk7Ci0KIAkJ TWVtb3J5Q29udGV4dERlbGV0ZSh0ZW1wQ29udGV4dCk7CiAJfQogCVBHX0VORF9UUlkoKTsKLS0g CjIuNDMuMAoK --=-mbNK+jemjYYLziKlyr4o--