Subject: Re: pgsql: SQL-standard function body
To: Laurenz Albe <laurenz.albe@cybertec.at>
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
 <cee01d26fe55bc086b3bcf10bfe4e8d450e2f608.camel@cybertec.at>
 <7466db64eb6abae93e583faf8ca4004d60c163c4.camel@cybertec.at>
 <823c7393-a2ca-c44a-c57a-b5ff84c3de28@enterprisedb.com>
 <a07142b8d7c541db97bf9403e1646d0fbf6cf614.camel@cybertec.at>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Message-ID: <f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com>
Date: Fri, 16 Apr 2021 12:26:16 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.1
MIME-Version: 1.0
In-Reply-To: <a07142b8d7c541db97bf9403e1646d0fbf6cf614.camel@cybertec.at>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f6852374-022c-29ec-4828-ae2c8a4e4668%40enterprisedb.com>
Precedence: bulk

On 12.04.21 21:00, Laurenz Albe wrote:
>>> Here is an improved patch, which treats END in the same fashion
>>> (not properly indented for readability).
>>
>> Thanks, I took another look at this and augmented your change with a
>> change that tracks whether the statement starts with CREATE [OR REPLACE]
>> {FUNCTION|PROCEDURE}.  That should make it pretty safe.  What do you think?
> 
> Thanks, that is fine with me and more than I asked for.
> That should definitely exclude all false positive matches.

committed