Message-ID: <f7bd155e-0bd4-4b09-86b3-92140af98654@iki.fi>
Date: Fri, 20 Feb 2026 23:01:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons
 from procsignals)
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <E1vpon6-002LVp-2z@gemulon.postgresql.org>
 <aYtMbb28qxqLrhvC@ip-10-97-1-34.eu-west-3.compute.internal>
 <a6159474-a06b-4874-9e4f-f06516995860@iki.fi>
 <aYtcMg5hMdGdhX4q@alap3.anarazel.de>
 <1cb0d7e9-d6dd-4517-a7cd-0ad98e1207f3@iki.fi>
 <aYtsrQ-kmA8nqeiH@alap3.anarazel.de>
 <aYuDz2kvi7haNORb@ip-10-97-1-34.eu-west-3.compute.internal>
 <aYuIrKbh1kW36xbc@alap3.anarazel.de>
 <3dd6f70c-b94d-4428-8e75-74a7136396be@iki.fi>
 <aYwISFVCAJon5ZxT@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <aYwISFVCAJon5ZxT@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/f7bd155e-0bd4-4b09-86b3-92140af98654%40iki.fi>
Precedence: bulk

On 11/02/2026 06:40, Bertrand Drouvot wrote:
> On Tue, Feb 10, 2026 at 10:53:58PM +0200, Heikki Linnakangas wrote:
> 0003:
> 
> 1/ There is one missing change in PrintLockQueue() ("links" is still used, and
> that should be replaced by "waitLink").
> 
> 2/ change the comment on top of ProcWakeup?
> 
> "
> /*
>   * ProcWakeup -- wake up a process by setting its latch.
>   *
>   *   Also remove the process from the wait queue and set its links invalid.
> "
> 
> s/links/waitLink/?

Fixed those and pushed this "Split PGPROC 'links' field into two, for 
clarity" patch. Thanks for the review!

- Heikki