Content-Type: multipart/mixed; boundary="------------43EWIrtTwUEmCGLSoZL6u0v0"
Message-ID: <fb969d8d-7ef5-471b-ae90-d20cdbf6660b@postgrespro.ru>
Date: Mon, 30 Mar 2026 04:30:56 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
To: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <johncnaylorls@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-committers@lists.postgresql.org
References: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
 <2862807.1663184226@sss.pgh.pa.us>
 <20220914205715.xbmuqox5htobzggy@awork3.anarazel.de>
 <20220914210427.y26tkagmxo5wwbvp@awork3.anarazel.de>
 <CAFBsxsGCoEpiSWUBxnkKFq5S0oNtfB9P+rOjXtgiNLZYDfXa5w@mail.gmail.com>
 <ac5ebc67-9a2f-4a95-88b2-7ac09e63dc3e@postgrespro.ru>
 <CANWCAZaCk6mX1c4oCQc9fzjtiVZ_Fh19dipOScy7XEjJqAd3gg@mail.gmail.com>
 <1368269.1760589291@sss.pgh.pa.us>
Content-Language: en-US
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
In-Reply-To: <1368269.1760589291@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/fb969d8d-7ef5-471b-ae90-d20cdbf6660b%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------43EWIrtTwUEmCGLSoZL6u0v0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

Sorry for the very long delay in responding, and thank you for your patience.
Regarding to previous points:

On 16.10.2025 07:19, John Naylor wrote:
> 
> Also, that fix
> was in response to a specific change in dependencies, so I don't see
> how it's directly applicable to earlier branches. Maybe there is
> something to be done here, but with such a sporadic failure, I'm not
> sure what.

On 16.10.2025 07:34, Tom Lane wrote:
> Yeah.  One build failure in three years does not sound to me like
> something to panic about.  It sounds more like a local problem.
> Also, I note that alligator is self-described as running a
> "gcc experimental (nightly build)" compiler, so temporary build
> glitches on it are hardly unexpected.

this all seems quite reasonable but i observe the same behavior
on earlier branches as well.
Using a pre-built source tree at REL_14/15_STABLE,
this reproduction:

cd src/backend/parser
rm -rf .deps/ gram.c scan.c *.o *.bc gram.h
make parser.bc

results in:

$ make parser.bc
/usr/lib/llvm-16/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang
-no-opaque-pointers -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -Wno-deprecated-non-prototype
-O2  -I. -I. -I../../../src/include -D_GNU_SOURCE  -I/usr/include/libxml2 -I/usr/local/include -flto=thin -emit-llvm
-c -o parser.bc parser.c
In file included from parser.c:25:
../../../src/include/parser/gramparse.h:29:10: fatal error: 'parser/gram.h' file not found
#include "parser/gram.h"
          ^~~~~~~~~~~~~~~
1 error generated.
make: *** [../../../src/Makefile.global:1084: parser.bc] Error 1


Also as a possible improvement perhaps make the fix less strictly?
I.e. replace each .bc file's dependency on all .o files
with a more weak dependency just on all .c files.
Namely use
$(patsubst %.o,%.bc, $(OBJS)): $(patsubst %.o,%.c, $(OBJS))
instead of:
$(patsubst %.o,%.bc, $(OBJS)): $(OBJS)

This should still ensure correct build ordering, and it
will run faster during parallel builds, since it won't wait
for absolutely all the object files to be created.

For example, rebuilding parser.bc would then require only
a single compiler call in src/backend/parser.
See the attached bc-depends-on-c.txt for details.


Best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
--------------43EWIrtTwUEmCGLSoZL6u0v0
Content-Type: text/plain; charset=UTF-8; name="bc-depends-on-c.txt.txt"
Content-Disposition: attachment; filename="bc-depends-on-c.txt.txt"
Content-Transfer-Encoding: base64

JCBtYWtlIHBhcnNlci5iYwonL3Vzci9iaW4vcGVybCcgLi9jaGVja19rZXl3b3Jkcy5wbCBn
cmFtLnkgLi4vLi4vLi4vc3JjL2luY2x1ZGUvcGFyc2VyL2t3bGlzdC5oCi91c3IvbG9jYWwv
YmluL2Jpc29uIC1Xbm8tZGVwcmVjYXRlZCAgLWQgLW8gZ3JhbS5jIGdyYW0ueQovdXNyL2xv
Y2FsL2Jpbi9mbGV4IC1iIC1DRiAtcCAtcCAtbydzY2FuLmMnIHNjYW4ubAonL3Vzci9iaW4v
cGVybCcgLi4vLi4vLi4vc3JjL3Rvb2xzL2ZpeC1vbGQtZmxleC1jb2RlLnBsICdzY2FuLmMn
Ci91c3IvbGliL2xsdm0tMTYvYmluL2NsYW5nIC1Xbm8taWdub3JlZC1hdHRyaWJ1dGVzIC1m
bm8tc3RyaWN0LWFsaWFzaW5nIC1md3JhcHYgLWZleGNlc3MtcHJlY2lzaW9uPXN0YW5kYXJk
IC1YY2xhbmcgLW5vLW9wYXF1ZS1wb2ludGVycyAtV25vLXVudXNlZC1jb21tYW5kLWxpbmUt
YXJndW1lbnQgLVduby1jb21wb3VuZC10b2tlbi1zcGxpdC1ieS1tYWNybyAtTzIgIC1JLiAt
SS4gLUkuLi8uLi8uLi9zcmMvaW5jbHVkZSAtRF9HTlVfU09VUkNFICAtSS91c3IvaW5jbHVk
ZS9saWJ4bWwyIC1JL3Vzci9sb2NhbC9pbmNsdWRlIC1mbHRvPXRoaW4gLWVtaXQtbGx2bSAt
YyAtbyBwYXJzZXIuYmMgcGFyc2VyLmMKCiQgbHMKYW5hbHl6ZS5jICAgICAgICAgIGdyYW0u
aCAgICAgICBNYWtlZmlsZSAgICAgcGFyc2VfY2xhdXNlLmMgICBwYXJzZV9jdGUuYyAgIHBh
cnNlX2Z1bmMuYyAgIHBhcnNlX29wZXIuYyAgIHBhcnNlci5jICAgICAgICAgIHBhcnNlX3R5
cGUuYyAgICAgc2Nhbi5jCmNoZWNrX2tleXdvcmRzLnBsICBncmFtcGFyc2UuaCAgbWVzb24u
YnVpbGQgIHBhcnNlX2NvZXJjZS5jICAgcGFyc2VfZW5yLmMgICBwYXJzZV9tZXJnZS5jICBw
YXJzZV9wYXJhbS5jICBwYXJzZV9yZWxhdGlvbi5jICBwYXJzZV91dGlsY21kLmMgIHNjYW4u
bApncmFtLmMgICAgICAgICAgICAgZ3JhbS55ICAgICAgIHBhcnNlX2FnZy5jICBwYXJzZV9j
b2xsYXRlLmMgIHBhcnNlX2V4cHIuYyAgcGFyc2Vfbm9kZS5jICAgcGFyc2VyLmJjICAgICAg
cGFyc2VfdGFyZ2V0LmMgICAgUkVBRE1FICAgICAgICAgICBzY2Fuc3VwLmM=

--------------43EWIrtTwUEmCGLSoZL6u0v0--