Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdXl-0001Jl-VS for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 01:19:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYdXk-0001Zg-KS for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 01:19:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdXk-0001ZX-Cf for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 01:19:52 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYdXh-0004KP-CL for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 01:19:50 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 58F2F2000A; Thu, 15 Sep 2022 01:19:42 +0000 (UTC) Message-ID: Date: Wed, 14 Sep 2022 21:19:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. Content-Language: en-US To: Tom Lane , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-09-14 We 18:41, Tom Lane wrote: > Use the terminology "WAL file" not "log file" more consistently. > > Referring to the WAL as just "log" invites confusion with the > postmaster log, so avoid doing that in docs and error messages. > Also shorten "WAL segment file" to just "WAL file" in various > places. The pg_upgrade part of this seems seriously awry (see buildfarm animal crake). We can't assume that the upgrade source is using the new wording. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com