Feedback-ID: ie0a040ee:Fastmail
Message-ID: <fdbbb468-2f8d-41af-96d0-daa9ac928fd2@eisentraut.org>
Date: Wed, 15 Jan 2025 23:14:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Change gist stratnum function to use CompareType
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
References: <E1tY0qC-001hzx-Gi@gemulon.postgresql.org>
 <CAAKRu_bbYbxnv4-gc0cJ29S6wwfxff-0MMueN1e0yTMT+Aam4g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAAKRu_bbYbxnv4-gc0cJ29S6wwfxff-0MMueN1e0yTMT+Aam4g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/fdbbb468-2f8d-41af-96d0-daa9ac928fd2%40eisentraut.org>
Precedence: bulk

On 15.01.25 22:36, Melanie Plageman wrote:
> On Wed, Jan 15, 2025 at 5:41 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> Change gist stratnum function to use CompareType
>>
>> This changes commit 7406ab623fe in that the gist strategy number
>> mapping support function is changed to use the CompareType enum as
>> input, instead of the "well-known" RT*StrategyNumber strategy numbers.
>>
>> This is a bit cleaner, since you are not dealing with two sets of
>> strategy numbers.  Also, this will enable us to subsume this system
>> into a more general system of using CompareType to define operator
>> semantics across index methods.
> 
> This appears to fail the headers_cpluspluscheck job in CI [1] with
> 
> /tmp/cirrus-ci-build/src/include/access/gist.h:251:63: error: use of
> enum ‘CompareType’ without previous declaration
> 251 | extern StrategyNumber GistTranslateStratnum(Oid opclass, enum
> CompareType cmp);

Fixed, thanks.