Content-Type: multipart/alternative;
 boundary="------------uYxrGVaDdNXFNsR0LPxJ5xMy"
Message-ID: <fece94f9-7b04-4af9-a95d-ba768593a49a@postgrespro.ru>
Date: Tue, 14 Jan 2025 02:51:47 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
To: Melanie Plageman <melanieplageman@gmail.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAAKRu_Z15QyTX5n-u4mdXbCWZAw4Y-XNrpQaxL7npOca7Z_PWA@mail.gmail.com>
 <202501132046.m4mcvxxswznu@alvherre.pgsql>
 <CAAKRu_bn7wXa2pwrD-1EOM=dZOW9oNj+cgpALrtzc4k-YbwXJA@mail.gmail.com>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: 
 <CAAKRu_bn7wXa2pwrD-1EOM=dZOW9oNj+cgpALrtzc4k-YbwXJA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/fece94f9-7b04-4af9-a95d-ba768593a49a%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------uYxrGVaDdNXFNsR0LPxJ5xMy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi!

On 14.01.2025 01:35, Melanie Plageman wrote:
> On Mon, Jan 13, 2025 at 3:46 PM Alvaro Herrera<alvherre@alvh.no-ip.org>  wrote:
>> On 2025-Jan-13, Melanie Plageman wrote:
>>
>>> Since I didn't hear back about this and I don't see an obvious
>>> alternative reorganization in guc_tables.c, I plan to just push the
>>> attached patch that updates only postgresql.conf.sample.
>> Apologies, I was very unclear -- I didn't want to talk about the
>> ordering of entries in the code, but the categorization.  See the
>> config_group_names list in guc_tables.c, which defines some groups.
>> Each setting belongs into a group, and those groups correspond to what
>> the sample config file lists as section/subsection titles and to the
>> grouping in the docs.  Also, this categorization affects how the entries
>> are listed in the pg_settings view and in "postgres --describe-config",
>> which feed from the same tables.
> Oh dear, I had no idea that these categories existed. I suppose I
> never paid attention to the category column in pg_settings nor used
> --describe-config. Attached is a patch to fix this. I checked both
> pg_settings and --describe-config output, and it seems to work.
>
> I'm quite sorry about the extra noise this is causing (especially for
> people with patch sets requiring rebasing).
>
>> Perhaps with your changes (assuming I read your commit message right),
>> we need new groups:
>> VACUUMING
>> VACUUMING_FREEZING
>> VACUUMING_AUTOVACUUM
> I've gone with VACUUM_AUTOVACUUM, VACUUM_COST_DELAY, and
> VACUUM_FREEZING, but I am open to feedback.

Looks good and convenient, thanks for the patch!

I noticed another guc autovacuum_work_mem, which belongs more to the 
autovacuum category in my opinion, although it belongs to RESOURCES_MEM, 
but in fact, only autovacuum uses it.

-- 
Regards,
Alena Rybakina
Postgres Professional

--------------uYxrGVaDdNXFNsR0LPxJ5xMy
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi!<br>
    </p>
    <div class="moz-cite-prefix">On 14.01.2025 01:35, Melanie Plageman
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAAKRu_bn7wXa2pwrD-1EOM=dZOW9oNj+cgpALrtzc4k-YbwXJA@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">On Mon, Jan 13, 2025 at 3:46 PM Alvaro Herrera <a class="moz-txt-link-rfc2396E" href="mailto:alvherre@alvh.no-ip.org">&lt;alvherre@alvh.no-ip.org&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">
On 2025-Jan-13, Melanie Plageman wrote:

</pre>
        <blockquote type="cite">
          <pre class="moz-quote-pre" wrap="">Since I didn't hear back about this and I don't see an obvious
alternative reorganization in guc_tables.c, I plan to just push the
attached patch that updates only postgresql.conf.sample.
</pre>
        </blockquote>
        <pre class="moz-quote-pre" wrap="">
Apologies, I was very unclear -- I didn't want to talk about the
ordering of entries in the code, but the categorization.  See the
config_group_names list in guc_tables.c, which defines some groups.
Each setting belongs into a group, and those groups correspond to what
the sample config file lists as section/subsection titles and to the
grouping in the docs.  Also, this categorization affects how the entries
are listed in the pg_settings view and in "postgres --describe-config",
which feed from the same tables.
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Oh dear, I had no idea that these categories existed. I suppose I
never paid attention to the category column in pg_settings nor used
--describe-config. Attached is a patch to fix this. I checked both
pg_settings and --describe-config output, and it seems to work.

I'm quite sorry about the extra noise this is causing (especially for
people with patch sets requiring rebasing).

</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">Perhaps with your changes (assuming I read your commit message right),
we need new groups:
VACUUMING
VACUUMING_FREEZING
VACUUMING_AUTOVACUUM
</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
I've gone with VACUUM_AUTOVACUUM, VACUUM_COST_DELAY, and
VACUUM_FREEZING, but I am open to feedback.
</pre>
    </blockquote>
    <br>
    <p><span style="white-space: pre-wrap">Looks good and convenient, thanks for the patch! </span></p>
    <p><span style="white-space: pre-wrap">I noticed another guc autovacuum_work_mem, which belongs more to the autovacuum category in my opinion, although it belongs to RESOURCES_MEM, but in fact, only autovacuum uses it.
</span></p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional</pre>
  </body>
</html>

--------------uYxrGVaDdNXFNsR0LPxJ5xMy--