Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4Ghv-0000jB-EF for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2019 03:06:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h4Ght-00007i-Nz for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2019 03:06:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4Ght-00007b-Ac for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2019 03:06:57 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4Ghq-0002f1-8U for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2019 03:06:56 +0000 Received: by mail-ot1-x342.google.com with SMTP id t7so3792523otk.8 for ; Wed, 13 Mar 2019 20:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=lOUb0zwu91PK5Rry4P67lxUOaQZc0RDQJWJK7mAF94w=; b=h/TP0BqngukTmbGoOqXm6BN6ar6Ij/DhS0g7APslyHWeJpeB/q4Z9lbOlMcwVEgw00 e2pOQgbCgQFfFXL1URFeaX9dSrNwlAv6VKVlk6CW+xwceSHeOeCL+V8lXU4/WP7k0m+i ho126M6TtNSXd4u+Jiqh3hRguR5lb+UHK5Goyul7t6VyiPpXv/W+RsIcUkKRykf808Co WgCAIwOYj1Lwy5ro5NfbCpkPLalbM7zh0uPeCZKSNui0mb7ExgDWd65DTSAoZoxXKlqK L84OiydJ81IIzbcwP0aMF6zJbDGdQmGfRg60CKcKf6lo4GDQFHq+87e6Vf35COHgyVCu G53w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=lOUb0zwu91PK5Rry4P67lxUOaQZc0RDQJWJK7mAF94w=; b=azWY0kzzDRu5sLFbjhZADYH0qxU7psr27SAgrBM3evlcQ2y+mbsnn6ITpHimVuTUj1 3U4ljemI3K9CuDgyYnvRiqtFjsbgnyM+C8JDwzxtd8W5da7g/LCXzCOZpLiFvk9zDd00 2qUXo6urVfmefdFEFU1sxMvlrrKcR/l+wngGO5XUcGpsDgDoVcVlO8sm8syw4v7OH2sY k5R65GsbWkfwp+jaYYdFdMyQOg0sRTZ45SEfoj3MMmelTzdo8inOWP2gaPDJzNNT2mdd Y+yf2kzCnkRpCJPPF8/25pHFajs4LMu7/6RuAwqvmLClBAsLaY0NK0BfDMw7oa+AxR9I LBHg== X-Gm-Message-State: APjAAAVVBPb3qV0Zn2WBVL4GAXOhpqymBeJxzVKq62sidBNqqpM0o6OP O3LI00O7dGWyZScI8buiTuFZ X-Google-Smtp-Source: APXvYqySiJmxWdwsSy6CEkAku5Ha3UmYlmQZW9Kpc4Stm9mcgwQn2RYjcBsp6HH5v98a0nGdTPPrIg== X-Received: by 2002:a9d:561a:: with SMTP id e26mr30168381oti.332.1552532813079; Wed, 13 Mar 2019 20:06:53 -0700 (PDT) Received: from [192.168.10.146] (99-10-92-30.lightspeed.rlghnc.sbcglobal.net. [99.10.92.30]) by smtp.gmail.com with ESMTPSA id k11sm5374566oia.16.2019.03.13.20.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 20:06:52 -0700 (PDT) From: Andrew Dunstan X-Google-Original-From: Andrew Dunstan Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10(). To: Tom Lane , Michael Paquier Cc: Postgres hackers , laetitia.avrot@gmail.com References: <20190313022159.GR13812@paquier.xyz> <24813.1552447002@sss.pgh.pa.us> <20190313050331.GT13812@paquier.xyz> <17820.1552514192@sss.pgh.pa.us> Openpgp: preference=signencrypt Autocrypt: addr=andrew.dunstan@2ndQuadrant.com; prefer-encrypt=mutual; keydata= xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB AAHNL0FuZHJldyBEdW5zdGFuIDxhbmRyZXcuZHVuc3RhbkAybmRRdWFkcmFudC5jb20+wsCY BBMBAgBCAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUJDyV6hBYhBOQ+WEYd/Hy/RGkV pZn6f8tZ/DuBBQJcH/EVAhkBAAoJEJn6f8tZ/DuB7BEH/iDWZEbVft2m2MT6SPjARzTupt/l xLLZ/Cl6n2US2hov5+fBbnR5xvECk/YCOfG9ICvKNlpFjceqNLRKStd8cmndnI+kDw91uNM2 hpL4aJMeW65XCHvqXlOLSwv5chBpXz9NG7FMaJ+q+59sWEWjcTNmjXgkEHn53y+1pc7nSLDe cr5ZI1aB3nGXRm1SoDY5PYZkUKMykW+YBZwgcs/Q5tRaE+siN7DKbz8E628+PerwAkmHPVXN MdJFD6gs4S0gDFA8IxcyIwZU2v4By+brzcJ9Se3FK5BYxBDHtaYZxgSrJAvOUOrLIZPQTQfL TtnVs3C3JTfrxCH1ceHtnA6dRuTOwE0ETspYWQEIANGc4zQULOxhbqO2dyD51YhqCNRmm9oK Waqf+wmW4tpDe/VVcxAnNizd4LWCHfzpb5cHAtGkOPePMfzWVf6nvdF7d3eglbtf59+zG7O7 llV0xSSoFiieQBsrGvqDInXYX/4mRRXMtyhM353/tixC9RWLs1oofyYmCPPXXY7h9R7en3B8 BoVrRFcdzlIY/NFNhFGW/9dkEiGjgna2Rk6e15kln4ZvFBWUg23p93w/pqXcxY6+k/8TEk+C 4R+M6w7o2PLGOjdZ+kPiUcw5H85zf/yZJwQXzisXaNduwWB6Vads9YC9dj6kPR1c4VGRqAaY L++LAEOqrlvm2TvqQqZRtnEAEQEAAcLAZQQYAQIADwIbDAUCXA6fpAUJDyV6xAAKCRCZ+n/L Wfw7geU4B/9vFFsVmWxerDWgNjyiK80zIPmlw/iwdUlU6FIu0JWLMg4093kvxBs7RMZV9hBq n3ekBvD4IvFsVLJrw9qzSI2FH3UeYy5WXpEs01Ppia60NOlvRDqXbryzuvfe+iYo6bVP3Ikr TPTNYL/BePUTD2DPvSI82SbGTyzuA7SJv6NRqqQDMIy1fU6KyQFLmQJp/QJyhKWzm9jWh8ee w8jVaoMY0Kbq5N7RqisEx1Lu/Iw646UphdYzQNymf+kbiU5Kf4I6DhzV8w9sie1Bo1juNj3I c5/fFJsmxljbnaDbXPcnFsur1Oo9mIHFakgWgOBMuxoWfjONiLjjLh/9+ZIqSSLX Message-ID: Date: Wed, 13 Mar 2019 23:06:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <17820.1552514192@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-MW List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/13/19 5:56 PM, Tom Lane wrote: > Michael Paquier writes: >> On Tue, Mar 12, 2019 at 11:16:42PM -0400, Tom Lane wrote: >>> I'm inclined to leave it as-is for a day or so and see if any >>> other failures turn up, before deciding what to do about it. >> Fine by me. > Well, so far jacana is the only critter that's shown any problem. > > I don't find any of the possible solutions to be super attractive: > > 1. Put in an explicit special case, along the lines of > > if (arg1 == 0.0) > result = arg1; /* Handle 0 and -0 explicitly */ > else > result = asinh(arg1); > > Aside from being ugly, this'd mean that our regression tests weren't > really exercising the library asinh function at all. Or we could possibly call the function and then turn a result of -0 into 0? cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services