Feedback-ID: id4a34324:Fastmail
Date: Tue, 1 Apr 2025 17:34:19 -0400
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Todd Cook <cookt@blackduck.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Noah Misch <noah@leadboat.com>
Subject: Re: TEMP_CONFIG vs test_aio
Message-ID: <lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll@vemlvmfgnbox>
References: <E1tzglG-0029Xu-0h@gemulon.postgresql.org>
 <zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5>
 <EF3AA62E-A317-4A6B-BA98-C03E7238A671@blackduck.com>
 <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>
 <7dc78fd9-0afc-484e-bcba-c6f58567ab81@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7dc78fd9-0afc-484e-bcba-c6f58567ab81@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/lon4dng6lffn4hamo3n654lo5w2zjadap3e437cdfr5lxdklll%40vemlvmfgnbox>
Precedence: bulk

Hi,

On 2025-04-01 17:08:49 -0400, Andrew Dunstan wrote:
> On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
> > For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
> > buildfarm code, because the buildfarm code filters out environment variables
> > that aren't on an allowlist (I really dislike that).
> 
> 
> Uh, not quite. Anything in the config's build_env is not filtered out. That
> change was made a year ago.

Huh. Just recently I tried to configure PG_TEST_TIMEOUT_DEFAULT in build_env
and did not take effect until I explicitly added it to the @safe_set.

Greetings,

Andres Freund