Message-ID: <00307b02220a8018baee6b35180a3e2bc4abecb2.camel@cybertec.at>
Subject: Re: small patch
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: rir <rirans@comcast.net>
Cc: pgsql-docs@lists.postgresql.org
Date: Mon, 11 Oct 2021 08:57:08 +0200
In-Reply-To: <20211010201501.7e35hmwmdxqynjko@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
	 <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
	 <20211007033905.pmsg5qnyqceepfva@localhost>
	 <9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
	 <20211007200612.rkxxgeorw6w4fpjp@localhost>
	 <57c6acf0d2936597184f6bc06f434c66eab07f49.camel@cybertec.at>
	 <20211010201501.7e35hmwmdxqynjko@localhost>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/00307b02220a8018baee6b35180a3e2bc4abecb2.camel%40cybertec.at>
Precedence: bulk

On Sun, 2021-10-10 at 16:15 -0400, rir wrote:
> On Fri, Oct 08, 2021 at 02:47:43PM +0200, Laurenz Albe wrote:
> > On Thu, 2021-10-07 at 16:06 -0400, rir wrote:
> 
> 
> > So I suggest that you change the syntax diagram to
> > 
> > FETCH [ direction ] [ FROM | IN ] cursor_name
> 
> > Then I agree that the "empty or" can be removed.
> 
> > I remain of the opinion that the comments should be
> > retained, but we can leave that for somebody else to
> > decide.
> 
> I accept your three points above.
> 
> The MOVE synopsis shows the same parsing as I presented,
> should it be changed in the same way (move a square bracket left to
> be after <direction>)?  My guess is yes, but I've never used an
> SQL cursor.
> 
> When this convo settles, I send a new patch.  Probably
> here in the group.  If I have a few more, or a complex one,
> I'll check out the other submission method.

Yes, I think that such a patch would meet with favor.

Make sure to register it on the commitfest.  To do that, it is better
to send the patch to the -hackers list.  The commitfest application
won't find conversations on the -docs list.

Yours,
Laurenz Albe