From: "Charles Clavadetscher" <clavadetscher@swisspug.org>
To: "'Stephen Frost'" <sfrost@snowman.net>
Cc: <pgsql-hackers@postgresql.org>
References: <016a01d0ede6$1fc6af00$5f540d00$@swisspug.org>
 <016c01d0edec$81975df0$84c619d0$@swisspug.org>
 <20150913123038.GF3685@tamriel.snowman.net>
In-Reply-To: <20150913123038.GF3685@tamriel.snowman.net>
Subject: Re: [DOCS] Missing COMMENT ON POLICY
Date: Sun, 13 Sep 2015 14:42:24 +0200
Message-ID: <01e601d0ee21$aa4deef0$fee9ccd0$@swisspug.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQH/prVH2eW7nY5uhvsZoFxPI8toTwIDZoNjAhQyyQ6dvDh+UA==
Content-Language: de-ch
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Hello Stephen

Yes, of course. I will take care of that and send a new patch.
Who will then git push it?

Thank you for your feedback.
Bye
Charles

> -----Original Message-----
> From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-
> owner@postgresql.org] On Behalf Of Stephen Frost
> Sent: Sonntag, 13. September 2015 14:31
> To: Charles Clavadetscher <clavadetscher@swisspug.org>
> Cc: pgsql-hackers@postgresql.org
> Subject: Re: [HACKERS] [DOCS] Missing COMMENT ON POLICY
> 
> Charles,
> 
> * Charles Clavadetscher (clavadetscher@swisspug.org) wrote:
> > Well I gave it a try. I am still not very well aware how the process for
> > suggesting or submitting corrections work, but this is as far as I got.
> > In the attachment is a patch for the missing entry for POLICY in the
> > documentation on COMMENT that I mentioned earlier on pgsql-docs.
> 
> Thanks!  This looks mostly correct but only goes half-way (not that
> there's a lot to this change ;).  The 'policy_name' parameter which is
> added should also be added to the 'Parameters' list below, and the
> description under 'table_name' updated to reflect that it's used for
> policies also.
> 
> There should probably be an example added also, since it looks like
> there are examples of pretty much all the other COMMENT ON
> types.
> 
> Thanks again!
> 
> Stephen


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers