Content-Type: multipart/mixed; boundary="------------umqrxtWBT404w3jTEOYTjNtT"
Message-ID: <065b1b54-dc4a-4a29-919d-76f89ce96532@gmail.com>
Date: Sun, 7 Jun 2026 10:00:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-docs@lists.postgresql.org
From: Ning Sun <classicning@gmail.com>
Subject: [PATCH] Correct the version sent in protocol negotiation
Autocrypt: addr=classicning@gmail.com; keydata=
 xsBNBFLot3sBCAC9j9CSDztY1mrFV4KkJjNp1HEuLpZnl/EDJKc+omEixTOWuE81R+YOBCV2
 e4f3w4ZZHxkJ5n57by1GUPDyMG4bBC3I27jeiGKz88D/6HmTRww2Z/amUJYB/RO8vOMzbO8+
 m4VnzrHwZe5qqFaw3AId+tF6+cehh8/Um61IlRsN0FGsyAJBox5FnnQAuGfRnUFypRVsrF3c
 iH5aweJVasl61nPxBAVw5WyPzvDqhnNhIT71nFr/94q7R8kjX/BrQ92cXPpLdzUO6AnNH3eD
 dGU7Jj/A63HCthVamZ6u7FgqcZLl1wZfdi+kJnlDnYTYVP1xpIXM2W5xkZWQcVU9/WlPABEB
 AAHNLk5pbmcgU3VuIChHb29nbGUgbWFpbCkgPGNsYXNzaWNuaW5nQGdtYWlsLmNvbT7CwI4E
 EwEIADgCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AWIQTtkdI0yulzZ5rUbqYuJ+IPxN7q
 PgUCZwVVIwAKCRAuJ+IPxN7qPvjIB/9ra9tReBTZUxYBGAv9k0ZEHpL9fhqwDLl1k+zGXwei
 h2Ty8UPAKKJ6QCGid5GTG8k4Em+zctf63whCKF350/a8VLzmEW/WFTP2lzmH7aRsSeguOYGn
 0azgE8y6RFwjRXAz4QLPR9uVOPhmQkFU0Qjfu+w3pJxmkmMqSmMcu6C44cICibSj3bt2DpWh
 e3r1yQUInJgCeM+IRdEICMjyGiY5O2rHr/IjCygf8Ya79kqSsfd6bu+IcKT230k8A+mbA7Pp
 OwwxAPdETIrHgW8yIZxFkz5JC0P4O4CdKvQNNOrBbFPuZyM8cSmIM4AQizwrGBQPG6uYnGXO
 8TkRtAcXPQZyzsBNBFepeMsBCADRNmte4eN4W/r72nzR4SVHEMJPBAaT1+DyJZ8Vk3f+g1l1
 PTlsESLLg2pJD0HvsdAith/dedhlf5+wFujl2CXvmF16gD1MYEcuDqQnjRwQb67qn3f3FIyZ
 Wheoa30cAN3G02eFLZoRlGZ08rHOhbt+wielOvrFSUA5jZMNpIQF9VlOYg46aE1lOHbsY42u
 AbOJq3FxTvtxWyxHA/PIrHu+eqzL4fS+bgYm8o5SFK/DQNhhfK3bw0f1TANKLHD0W65NI3BS
 P7FKQC4QnStADh2d+qupEDlRQpC5+Wi+OaSujHKLMsz6vci8nz6/6Ki7n3qiOLjsXoOBGeVg
 USX+iTL3ABEBAAHCwF8EGAEIAAkFAlepeMsCGwwACgkQLifiD8Te6j4MBgf+NMZ7/zcnDMHf
 w/D0huW7h9wNDbipS+T+gEwKU1ILt/FDnws7+cktFHWETFsjlAkSSincBXK+kSOF10FKaLP6
 Z/7GxOigC9g8PsImCrNIyYTc64DEKXmA8xUou2SUbbh4M2/lIAVhre2t8NbwtTZD7BaBbdSp
 WPETU7DCDbm1TZ3tzRvYTPqtIOWKgganBipNyk6QgV3PkkDmJykPotjlOqyWV50Kugk6X3I1
 kMoU67+5GTUt3XBiM0fxMyay6OCb2dfRwUirOYHXpIhW2nULjxGjpFCEMl6hVRSt99tLZhpo
 Ux0a6Fn6ug0F6kJYHfurJqo055cKbqfGjIFlcenqHg==
Archived-At: 
 <https://www.postgresql.org/message-id/065b1b54-dc4a-4a29-919d-76f89ce96532%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------umqrxtWBT404w3jTEOYTjNtT
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Our protocol doc describes protocol negotiation message will send latest 
minor version. However that field is a 4-byte one. The actual 
implementation sends full version including the major part:

static void
SendNegotiateProtocolVersion(List *unrecognized_protocol_options)
{
     StringInfoData buf;
     ListCell   *lc;

     pq_beginmessage(&buf, PqMsg_NegotiateProtocolVersion);
     pq_sendint32(&buf, FrontendProtocol);
     pq_sendint32(&buf, list_length(unrecognized_protocol_options));
     foreach(lc, unrecognized_protocol_options)
         pq_sendstring(&buf, lfirst(lc));
     pq_endmessage(&buf);

     /* no need to flush, some other message will follow */
}

The patch included just clarifies this behavior by removing "minor" from 
"newest minor version".


--------------umqrxtWBT404w3jTEOYTjNtT
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Protocol-negotiation-sends-full-version-instead-of-m.patch"
Content-Disposition: attachment;
 filename*0="0001-Protocol-negotiation-sends-full-version-instead-of-m.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAxYmIwMGU3OTJmYmVmYTFkY2Y2ZTcyZmRkYjdiYWFjMTQwMGM0ZGVlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBOaW5nIFN1biA8c3VubmluZ0BncmVwdGltZS5jb20+
CkRhdGU6IFNhdCwgNiBKdW4gMjAyNiAxODo1MTo1OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd
IFByb3RvY29sIG5lZ290aWF0aW9uIHNlbmRzIGZ1bGwgdmVyc2lvbiBpbnN0ZWFkIG9mIG1p
bm9yCgotLS0KIGRvYy9zcmMvc2dtbC9wcm90b2NvbC5zZ21sIHwgOCArKysrLS0tLQogMSBm
aWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9kb2Mvc3JjL3NnbWwvcHJvdG9jb2wuc2dtbCBiL2RvYy9zcmMvc2dtbC9wcm90b2Nv
bC5zZ21sCmluZGV4IDQ5ZjgxNjc2NzEyLi44N2RiYzA5YWYwNyAxMDA2NDQKLS0tIGEvZG9j
L3NyYy9zZ21sL3Byb3RvY29sLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3Byb3RvY29sLnNn
bWwKQEAgLTYwMiw4ICs2MDIsOCBAQAogICAgICAgIDxwYXJhPgogICAgICAgICBUaGUgc2Vy
dmVyIGRvZXMgbm90IHN1cHBvcnQgdGhlIG1pbm9yIHByb3RvY29sIHZlcnNpb24gcmVxdWVz
dGVkCiAgICAgICAgIGJ5IHRoZSBjbGllbnQsIGJ1dCBkb2VzIHN1cHBvcnQgYW4gZWFybGll
ciB2ZXJzaW9uIG9mIHRoZSBwcm90b2NvbDsKLSAgICAgICAgdGhpcyBtZXNzYWdlIGluZGlj
YXRlcyB0aGUgaGlnaGVzdCBzdXBwb3J0ZWQgbWlub3IgdmVyc2lvbi4gIFRoaXMKLSAgICAg
ICAgbWVzc2FnZSB3aWxsIGFsc28gYmUgc2VudCBpZiB0aGUgY2xpZW50IHJlcXVlc3RlZCB1
bnN1cHBvcnRlZCBwcm90b2NvbAorICAgICAgICB0aGlzIG1lc3NhZ2UgaW5kaWNhdGVzIHRo
ZSBoaWdoZXN0IHN1cHBvcnRlZCB2ZXJzaW9uLiBUaGlzIG1lc3NhZ2UKKyAgICAgICAgd2ls
bCBhbHNvIGJlIHNlbnQgaWYgdGhlIGNsaWVudCByZXF1ZXN0ZWQgdW5zdXBwb3J0ZWQgcHJv
dG9jb2wKICAgICAgICAgb3B0aW9ucyAoaS5lLiwgYmVnaW5uaW5nIHdpdGggPGxpdGVyYWw+
X3BxXy48L2xpdGVyYWw+KSBpbiB0aGUKICAgICAgICAgc3RhcnR1cCBwYWNrZXQuCiAgICAg
ICAgPC9wYXJhPgpAQCAtNTQ1MCw4ICs1NDUwLDggQEAgcHNxbCAiZGJuYW1lPXBvc3RncmVz
IHJlcGxpY2F0aW9uPWRhdGFiYXNlIiAtYyAiSURFTlRJRllfU1lTVEVNOyIKICAgICAgICA8
dGVybT5JbnQzMjwvdGVybT4KICAgICAgICA8bGlzdGl0ZW0+CiAgICAgICAgIDxwYXJhPgot
ICAgICAgICAgTmV3ZXN0IG1pbm9yIHByb3RvY29sIHZlcnNpb24gc3VwcG9ydGVkIGJ5IHRo
ZSBzZXJ2ZXIKLSAgICAgICAgIGZvciB0aGUgbWFqb3IgcHJvdG9jb2wgdmVyc2lvbiByZXF1
ZXN0ZWQgYnkgdGhlIGNsaWVudC4KKyAgICAgICAgIE5ld2VzdCBwcm90b2NvbCB2ZXJzaW9u
IHN1cHBvcnRlZCBieSB0aGUgc2VydmVyIGZvciB0aGUKKyAgICAgICAgIG1ham9yIHByb3Rv
Y29sIHZlcnNpb24gcmVxdWVzdGVkIGJ5IHRoZSBjbGllbnQuCiAgICAgICAgIDwvcGFyYT4K
ICAgICAgICA8L2xpc3RpdGVtPgogICAgICAgPC92YXJsaXN0ZW50cnk+Ci0tIAoyLjU0LjAK
Cg==

--------------umqrxtWBT404w3jTEOYTjNtT--