From: Tobias Bussmann <t.bussmann@gmx.net>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Docs for Generated Columns
Message-Id: <071F9108-0335-4309-ACD3-262AF04A1817@gmx.net>
Date: Thu, 23 May 2019 23:50:12 +0200
To: pgsql-docs@lists.postgresql.org
Precedence: bulk

Hi,

while reading though the docs of the upcoming pg12 features, I stumbled =
upon some wording regarding generated columns:

both in create_table.sgml [1] and create_foreign_table.sgml [2] the =
paragraph for the GENERATED ALWAYS AS clause is introduced with=20

> This clause creates the column as a generated column. The column =
cannot be written to, and when read it will be computed from the =
specified expression.

To me this sounds confusing, if not wrong. Till v8 of the patch were =
STORED and VIRTUAL generated columns were described afterwards this was =
less obvious but now with only STORED it sounds like a reference to the =
VIRTUAL variant. Not being I native english speaker I'm restrained to =
send a patch but may I suggest the following for discussion:

  The column cannot be written to, and when read the result of the =
specified expression will be returned.

Best regards
Tobias Bussmann

[1]: https://www.postgresql.org/docs/devel/sql-createtable.html
[2]: https://www.postgresql.org/docs/devel/sql-createforeigntable.html=