pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedGiST for 7.1 !!
5+ messages / 4 participants
[nested] [flat]
* GiST for 7.1 !!
@ 2001-01-10 12:06 Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Bartunov @ 2001-01-10 12:06 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Hi,
we've almost totally rewrite gist.c because old code and algorithm
were not suitable for variable size keys. I think it might be
submitted into 7.1 beta source tree. We have fixed several bugs and
memory leaks. Version for 7.0.3 is also available.
Sampe application for contrib area - implementation RD-Tree and index support
for int arrays I'll submit later (Need some documentation).
Regards,
Oleg
Here is a README.gist
--------------------------------
New version of gist.c for PostgreSQL 7.1
New feature:
1. Support of variable size keys - new algorithm of insertion to tree
(GLI - gist layrered insertion). Previous algorithm was implemented
as described in paper by Joseph M. Hellerstein et.al
"Generalized Search Trees for Database Systems". This (old)
algorithm was not suitable for variable size keys and could be
not effective ( walking up-down ) in case of multiple levels split
Bug fixed:
1. fixed bug in gistPageAddItem - key values were written to disk
uncompressed. This caused failure if decompression function
does real job.
2. NULLs handling - we keep NULLs in tree. Right way is to remove them,
but we don't know how to inform vacuum about index statistics. This is
just cosmetic warning message (like in case with R-Tree),
but I'm not sure how to recognize real problem if we remove NULLs
and suppress this warning as Tom suggested.
3. various memory leaks
All our tests and Gene Selcov's regression tests passed ok.
We have version also for 7.0.3
Sample application which utilize RD-Tree for index support of
int arrays is in contrib/intarray (will be submitted separately).
TODO:
1. Description of GLI algorithm
2. regression test for GiST (based on RD-Tree)
This work was done by Teodor Sigaev (teodor@stack.net) and
Oleg Bartunov (oleg@sai.msu.su).
On Sun, 17 Dec 2000, Tom Lane wrote:
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > I checked 7.1 feature list and didn't find any mention about GiST
> > but there are changes in GiST code. Who is a maintainer of GiST code ?
>
> You are ;-). If you expect to find someone who understands GiST better
> than you, you're probably out of luck.
>
> I recall having made a number of changes that applied to all of the
> index access methods, including GiST --- but I was just changing
> similar code in all the methods. I don't claim to know anything
> about GiST in particular.
>
> regards, tom lane
>
Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
Attachments:
gist-7.1.tar.gz (application/octet-stream, 10.3K) download
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: GiST for 7.1 !!
@ 2001-01-11 02:49 Tom Lane <tgl@sss.pgh.pa.us>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2001-01-11 02:49 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg Bartunov <oleg@sai.msu.su> writes:
> we've almost totally rewrite gist.c because old code and algorithm
> were not suitable for variable size keys. I think it might be
> submitted into 7.1 beta source tree.
Urgh. Dropping in a total rewrite when we're already past beta3 doesn't
strike me as good project management practice --- especially if the
rewrite was done to add features (ie variable-size keys) not merely
fix bugs. I think it might be more prudent to hold this for 7.2.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Re: GiST for 7.1 !!
@ 2001-01-11 10:09 Oleg Bartunov <oleg@sai.msu.su>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: Oleg Bartunov @ 2001-01-11 10:09 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
On Wed, 10 Jan 2001, Tom Lane wrote:
> Oleg Bartunov <oleg@sai.msu.su> writes:
> > we've almost totally rewrite gist.c because old code and algorithm
> > were not suitable for variable size keys. I think it might be
> > submitted into 7.1 beta source tree.
>
> Urgh. Dropping in a total rewrite when we're already past beta3 doesn't
> strike me as good project management practice --- especially if the
> rewrite was done to add features (ie variable-size keys) not merely
> fix bugs. I think it might be more prudent to hold this for 7.2.
OK. If our changes will not go to 7.1, is't possible to create
feature archive and announce it somewhere. It would be nice if
people could test it. Anyway, I'll create web page with all
docs and patches. I'm afraid one more year to 7.2 is enough for
GiST to die :-)
>
> regards, tom lane
>
Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Re: GiST for 7.1 !!
@ 2001-01-11 13:50 The Hermit Hacker <scrappy@hub.org>
parent: Oleg Bartunov <oleg@sai.msu.su>
0 siblings, 1 reply; 5+ messages in thread
From: The Hermit Hacker @ 2001-01-11 13:50 UTC (permalink / raw)
To: Oleg Bartunov <oleg@sai.msu.su>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
Oleg ... how about a contrib/patches directory that we put this into for
v7.1 release, so that ppl have access to it, and then we apply the patch
first thing for part of v7.2?
On Thu, 11 Jan 2001, Oleg Bartunov wrote:
> On Wed, 10 Jan 2001, Tom Lane wrote:
>
> > Oleg Bartunov <oleg@sai.msu.su> writes:
> > > we've almost totally rewrite gist.c because old code and algorithm
> > > were not suitable for variable size keys. I think it might be
> > > submitted into 7.1 beta source tree.
> >
> > Urgh. Dropping in a total rewrite when we're already past beta3 doesn't
> > strike me as good project management practice --- especially if the
> > rewrite was done to add features (ie variable-size keys) not merely
> > fix bugs. I think it might be more prudent to hold this for 7.2.
>
> OK. If our changes will not go to 7.1, is't possible to create
> feature archive and announce it somewhere. It would be nice if
> people could test it. Anyway, I'll create web page with all
> docs and patches. I'm afraid one more year to 7.2 is enough for
> GiST to die :-)
>
> >
> > regards, tom lane
> >
>
> Regards,
> Oleg
> _____________________________________________________________
> Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
> Sternberg Astronomical Institute, Moscow University (Russia)
> Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
> phone: +007(095)939-16-83, +007(095)939-23-83
>
>
Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Re: GiST for 7.1 !!
@ 2001-01-11 16:26 Hannu Krosing <hannu@tm.ee>
parent: The Hermit Hacker <scrappy@hub.org>
0 siblings, 0 replies; 5+ messages in thread
From: Hannu Krosing @ 2001-01-11 16:26 UTC (permalink / raw)
To: The Hermit Hacker <scrappy@hub.org>; +Cc: Oleg Bartunov <oleg@sai.msu.su>; Tom Lane <tgl@sss.pgh.pa.us>; Bruce Momjian <pgman@candle.pha.pa.us>; PostgreSQL-development <pgsql-hackers@postgresql.org>
The Hermit Hacker wrote:
>
> Oleg ... how about a contrib/patches directory that we put this into for
> v7.1 release, so that ppl have access to it, and then we apply the patch
> first thing for part of v7.2?
And have Mandrake ship postgresql-v7.1-GiST-1mdk.rpm by default ;)
I would even vote for including the ability to index int(4) arrays in
the
main distribution and not in contrib, similar to the current state of
plpgsq
and other pl* - ie they are compiled by default but not "activated".
Assumption that arrays are indexable seems to come up once or twice a
month on the mailing lists.
-------------------
Hannu
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2001-01-11 16:26 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2001-01-10 12:06 GiST for 7.1 !! Oleg Bartunov <oleg@sai.msu.su>
2001-01-11 02:49 ` Tom Lane <tgl@sss.pgh.pa.us>
2001-01-11 10:09 ` Oleg Bartunov <oleg@sai.msu.su>
2001-01-11 13:50 ` The Hermit Hacker <scrappy@hub.org>
2001-01-11 16:26 ` Hannu Krosing <hannu@tm.ee>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox