Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 10F791337B58 for ; Sun, 27 Feb 2011 13:40:26 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 79211-07 for ; Sun, 27 Feb 2011 17:40:18 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id A07361337B4E for ; Sun, 27 Feb 2011 13:40:18 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p1RHeEd8010716; Sun, 27 Feb 2011 12:40:14 -0500 (EST) To: Bruce Momjian cc: Peter Eisentraut , Robert Haas , Josh Kupershmidt , pgsql-docs@postgresql.org Subject: Re: Documenting removal of nonnullvalue() and friends In-reply-to: <201102271727.p1RHR7a04699@momjian.us> References: <201102271727.p1RHR7a04699@momjian.us> Comments: In-reply-to Bruce Momjian message dated "Sun, 27 Feb 2011 12:27:07 -0500" Date: Sun, 27 Feb 2011 12:40:14 -0500 Message-ID: <10715.1298828414@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201102/81 X-Sequence-Number: 6429 Bruce Momjian writes: > Tom Lane wrote: >> I thought about this a bit more last night. It's certainly true that >> a lot of "internal" functions have comments that don't suggest that >> they're not meant to be used directly. What I think would be a good >> plan for functions that underlie operators is that we move any useful >> comments from pg_proc to pg_operator, and then install a comment in >> pg_proc that says "implementation of operator +" (or whatever the >> operator name is). >> ... >> If that sounds like a reasonable plan, I'm willing to have a go at it >> after the commitfest closes. > Tom, any work on this? A TODO? I haven't done anything about this yet, but it's still on my to-do list. Right now (or at least after I finish the patches I'm working on) would probably be about the best possible time to do it, since hopefully we have the minimum number of unapplied patches that would need to be revised to follow the new convention. regards, tom lane