agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedError in example
6+ messages / 4 participants
[nested] [flat]
* Error in example
@ 2018-12-19 12:33 PG Doc comments form <noreply@postgresql.org>
2018-12-19 15:07 ` Re: Error in example Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2018-12-19 12:33 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: glauciobb@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/spi-examples.html
Description:
Dear,
In the example of how to use SPI in the following link
https://www.postgresql.org/docs/10/spi-examples.html
The parameters numbers in the follow lines are wrong.
/ * Convert a text object to a C string * /
command = text_to_cstring (PG_GETARG_TEXT_PP (1));
cnt = PG_GETARG_INT32 (2);
They should be as follow:
/ * Convert a text object to a C string * /
command = text_to_cstring (PG_GETARG_TEXT_PP (0));
cnt = PG_GETARG_INT32 (1);
Best regards,
Gláucio
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Error in example
2018-12-19 12:33 Error in example PG Doc comments form <noreply@postgresql.org>
@ 2018-12-19 15:07 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2018-12-19 15:07 UTC (permalink / raw)
To: glauciobb@gmail.com; +Cc: pgsql-docs@lists.postgresql.org
=?utf-8?q?PG_Doc_comments_form?= <noreply@postgresql.org> writes:
> In the example of how to use SPI in the following link
> https://www.postgresql.org/docs/10/spi-examples.html
> The parameters numbers in the follow lines are wrong.
> / * Convert a text object to a C string * /
> command = text_to_cstring (PG_GETARG_TEXT_PP (1));
> cnt = PG_GETARG_INT32 (2);
You're right. Will fix, thanks for the report!
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Error in Example
@ 2023-08-30 23:29 PG Doc comments form <noreply@postgresql.org>
2023-09-01 15:16 ` Re: Error in Example Erik Wienhold <ewie@ewie.name>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2023-08-30 23:29 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: evasquezg97@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/15/indexes-partial.html
Description:
The IP addresses used to exemplify which one will be covered by the partial
index are inverted.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Error in Example
2023-08-30 23:29 Error in Example PG Doc comments form <noreply@postgresql.org>
@ 2023-09-01 15:16 ` Erik Wienhold <ewie@ewie.name>
0 siblings, 0 replies; 6+ messages in thread
From: Erik Wienhold @ 2023-09-01 15:16 UTC (permalink / raw)
To: evasquezg97@gmail.com; pgsql-docs@lists.postgresql.org
On 31/08/2023 01:29 CEST PG Doc comments form <noreply@postgresql.org> wrote:
> Page: https://www.postgresql.org/docs/15/indexes-partial.html
> Description:
>
> The IP addresses used to exemplify which one will be covered by the partial
> index are inverted.
No, the example is correct. It's about only indexing addresses outside some
hypothetical organization's subnet 192.168.100.0/24. Notice that the index
predicate is negated.
Of course the predicate could be written without inverting the range:
WHERE (client_ip <= inet '192.168.100.0' OR
client_ip >= inet '192.168.100.255')
--
Erik
^ permalink raw reply [nested|flat] 6+ messages in thread
* Error in example
@ 2025-09-29 14:09 PG Doc comments form <noreply@postgresql.org>
2025-09-29 17:07 ` Error in example David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2025-09-29 14:09 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: franz-josef.faerber@stmuk.bayern.de
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/ddl-generated-columns.html
Description:
On page https://www.postgresql.org/docs/current/ddl-generated-columns.html :
In the example "CREATE TABLE people" ...,
the line "GENERATED ALWAYS AS ..." is missing the mandatory suffix word
"STORED".
Regards,
fjf2002
^ permalink raw reply [nested|flat] 6+ messages in thread
* Error in example
2025-09-29 14:09 Error in example PG Doc comments form <noreply@postgresql.org>
@ 2025-09-29 17:07 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: David G. Johnston @ 2025-09-29 17:07 UTC (permalink / raw)
To: franz-josef.faerber@stmuk.bayern.de <franz-josef.faerber@stmuk.bayern.de>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Monday, September 29, 2025, PG Doc comments form <noreply@postgresql.org>
wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/ddl-generated-columns.html
> Description:
>
> On page https://www.postgresql.org/docs/current/ddl-generated-columns.html
> :
>
> In the example "CREATE TABLE people" ...,
> the line "GENERATED ALWAYS AS ..." is missing the mandatory suffix word
> "STORED".
>
>
Read the sentence immediately following that example.
As of version 18 it is no longer mandatory.
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-09-29 17:07 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 12:33 Error in example PG Doc comments form <noreply@postgresql.org>
2018-12-19 15:07 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-08-30 23:29 Error in Example PG Doc comments form <noreply@postgresql.org>
2023-09-01 15:16 ` Re: Error in Example Erik Wienhold <ewie@ewie.name>
2025-09-29 14:09 Error in example PG Doc comments form <noreply@postgresql.org>
2025-09-29 17:07 ` David G. Johnston <david.g.johnston@gmail.com>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox