Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id 56F049FA1E2 for ; Fri, 10 Nov 2006 23:51:43 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 74856-09 for ; Fri, 10 Nov 2006 23:51:40 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey- Received: from mx1-p.vodamail.co.za (mx2.3g.vodacom.co.za [196.207.32.251]) by postgresql.org (Postfix) with ESMTP id 4797D9FA18C for ; Fri, 10 Nov 2006 23:51:38 -0400 (AST) Received: from localhost (localhost [127.0.0.1]) by mx1-p.vodamail.co.za (Postfix) with ESMTP id 44BF764002B for ; Sat, 11 Nov 2006 05:51:36 +0200 (SAST) Received: from mx1-p.vodamail.co.za ([127.0.0.1]) by localhost (mx1.vodamail.co.za [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 09622-05 for ; Sat, 11 Nov 2006 05:51:35 +0200 (SAST) Received: from josh.flame2.flame.co.za (unknown [10.53.22.11]) by mx1-p.vodamail.co.za (Postfix) with ESMTP id 26737640024 for ; Sat, 11 Nov 2006 05:51:34 +0200 (SAST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by josh.flame2.flame.co.za (8.13.7/8.13.7) with ESMTP id kAB3oLlP002644 for ; Sat, 11 Nov 2006 05:50:45 +0200 Subject: Re: Documentation update for PQexecParams From: Theo Kramer Reply-To: theo@flame.co.za To: pgsql-docs@postgresql.org In-Reply-To: <2471.1163197450@sss.pgh.pa.us> References: <1163009239.2384.2.camel@josh> <20061109144348.GA10157@fetter.org> <1163084688.2448.28.camel@theo-laptop.int.coza.net.za> <200611101050.43400.peter_e@gmx.net> <1163152973.2422.14.camel@theo-laptop.int.coza.net.za> <2471.1163197450@sss.pgh.pa.us> Content-Type: text/plain Organization: Flame Computing Enterprises cc Date: Sat, 11 Nov 2006 05:50:20 +0200 Message-Id: <1163217020.2431.20.camel@josh> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit X-Virus-Scanned: amavisd-new at vodamail.co.za X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200611/9 X-Sequence-Number: 3843 On Fri, 2006-11-10 at 17:24 -0500, Tom Lane wrote: > Theo Kramer writes: > > On Fri, 2006-11-10 at 10:50 +0100, Peter Eisentraut wrote: > >> The patch is backwards. > > > Thanks - re-done and re-attached > > I applied the part of this that reformats the PQexecParams argument > descriptions --- I agree that makes it more readable. I did not like > the proposed table of datatypes though. It strikes me as incomplete, > unhelpful, and in places downright misleading. For instance, I don't > see the point of listing ODBC type codes; they are irrelevant to libpq, > and the only likely outcome of listing them is that someone might think > he could use them for paramTypes[] entries. The description of the > binary formats was not helpful either, as it avoided any of the useful > details (endianness etc), as well as portability issues like whether > timestamps are int or float. > Thanks for the input - I agree that the table is incomplete. My intention with the table is for it to be a start to something that is more useful than the incomplete examples regarding these functions. I suggest I redo it taking into consideration your input, unless you have other suggestions for improving the docs on the use with typical values for the arguments. On the ODBC types - I found these useful as my interface is based on that. I imagine that others who have used ODBC and who would like to use the libpq functions may also find it useful, but also agree that it may be misleading. Perhaps, with a couple of iterations, we can get to something that will make the documentation on these functions more useful. -- Regards Theo