Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 39E50634FF4
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 11 Feb 2010 14:08:54 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 91548-02
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Thu, 11 Feb 2010 18:08:33 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id F1E76632845
	for <pgsql-hackers@postgresql.org>;
	Thu, 11 Feb 2010 14:08:34 -0400 (AST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o1BI8O1C011742;
	Thu, 11 Feb 2010 13:08:24 -0500 (EST)
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
cc: Aidan Van Dyk <aidan@highrise.ca>, Simon Riggs <simon@2ndQuadrant.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry
	restoring the next WAL
In-reply-to: <4B7438A9.8090902@enterprisedb.com> 
References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com>
	<4B726120.80007@enterprisedb.com>
	<1265884657.7341.1192.camel@ebony>
	<4B73F678.8070109@enterprisedb.com>
	<1265891248.7341.1346.camel@ebony>
	<4B73FB99.4080403@enterprisedb.com>
	<1265893599.7341.1454.camel@ebony>
	<4B740613.5090004@enterprisedb.com>
	<20100211140118.GB14128@oak.highrise.ca>
	<4B74118C.30704@enterprisedb.com>
	<20100211144204.GC14128@oak.highrise.ca>
	<4B7438A9.8090902@enterprisedb.com>
Comments: In-reply-to Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
	message dated "Thu, 11 Feb 2010 19:04:41 +0200"
Date: Thu, 11 Feb 2010 13:08:24 -0500
Message-ID: <11741.1265911704@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.466 tagged_above=-10 required=5 tests=AWL=0.133,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/908
X-Sequence-Number: 157251

Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> -1. it isn't necessary for PITR. It's a new requirement for
> standby_mode='on', unless we add the file size check into the backend. I
> think we should add the file size check to the backend instead and save
> admins the headache.

I think the file size check needs to be in the backend purely on safety
grounds.  Whether we make pg_standby useful for this context is a
different discussion.

			regards, tom lane