pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedmake cross link to "format" more specific
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2018-12-07 eeee62d805 4c6d6acec5 Doc: make cross-reference to format() function more specific.
* make cross link to "format" more specific
@ 2018-12-07 13:49 Jeff Janes <jeff.janes@gmail.com>
2018-12-07 15:41 ` Re: make cross link to "format" more specific Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Janes @ 2018-12-07 13:49 UTC (permalink / raw)
To: pgsql-docs
The section on dynamic SQL recommends "format", but the cross link goes to
the top of page 9.4 not the "format" specific 9.4.1.
This is particularly confusing as 9.4 only has one sub-section, so the TOC
at the top of the page only has one entry. This makes it look more like a
section header itself rather than a TOC. Leading you to believe you are
already at the specific section you want.
I don't know what to do about the visual misleadingness of single-entry
TOCs in general, but at least we can make this specific cross reference
more specific.
Cheers,
Jeff
Attachments:
string-function-format.patch (application/octet-stream, 564B) download
diff --git a/doc/src/sgml/plpgsql.sgml b/doc/src/sgml/plpgsql.sgml
index b9eb98c..1f2abbb 100644
--- a/doc/src/sgml/plpgsql.sgml
+++ b/doc/src/sgml/plpgsql.sgml
@@ -1414,7 +1414,7 @@ EXECUTE 'UPDATE tbl SET '
<para>
Dynamic SQL statements can also be safely constructed using the
<function>format</function> function (see <xref
- linkend="functions-string"/>). For example:
+ linkend="functions-string-format"/>). For example:
<programlisting>
EXECUTE format('UPDATE tbl SET %I = %L '
'WHERE key = %L', colname, newvalue, keyvalue);
* Re: make cross link to "format" more specific
2018-12-07 13:49 make cross link to "format" more specific Jeff Janes <jeff.janes@gmail.com>
@ 2018-12-07 15:41 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2018-12-07 15:41 UTC (permalink / raw)
To: Jeff Janes <jeff.janes@gmail.com>; +Cc: pgsql-docs
Jeff Janes <jeff.janes@gmail.com> writes:
> I don't know what to do about the visual misleadingness of single-entry
> TOCs in general, but at least we can make this specific cross reference
> more specific.
Agreed, done.
regards, tom lane
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-12-07 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 13:49 make cross link to "format" more specific Jeff Janes <jeff.janes@gmail.com>
2018-12-07 15:41 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox