Received: from localhost (unknown [200.46.204.183])
	by postgresql.org (Postfix) with ESMTP id 6655E9FA579
	for <pgsql-docs-postgresql.org@postgresql.org>;
	Tue, 25 Sep 2007 06:41:27 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 85536-06 for <pgsql-docs-postgresql.org@postgresql.org>;
	Tue, 25 Sep 2007 06:41:22 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.5
Received: from outmail136034.authsmtp.co.uk (outmail136034.authsmtp.co.uk
	[62.13.136.34]) by postgresql.org (Postfix) with ESMTP id 7475D9FA57C
	for <pgsql-docs@postgresql.org>; Tue, 25 Sep 2007 06:41:22 -0300 (ADT)
Received: from outmail128178.authsmtp.net (outmail128178.authsmtp.net
	[62.13.128.178])
	by punt3.authsmtp.com (8.13.8/8.13.8/Kp) with ESMTP id l8P9fLiC017583
	for <pgsql-docs@postgresql.org>; Tue, 25 Sep 2007 10:41:21 +0100 (BST)
Received: from [192.168.0.3] (85-211-149-22.dyn.gotadsl.co.uk [85.211.149.22])
	(authenticated bits=0)
	by mail.authsmtp.com (8.13.8/8.13.8/Kp) with ESMTP id l8P9fKN0033033
	for <pgsql-docs@postgresql.org>; Tue, 25 Sep 2007 10:41:20 +0100 (BST)
Subject: when transaction commit begins
From: Simon Riggs <simon@2ndquadrant.com>
To: pgsql-docs@postgresql.org
Content-Type: text/plain
Date: Tue, 25 Sep 2007 10:40:01 +0100
Message-Id: <1190713201.4181.350.camel@ebony.site>
Mime-Version: 1.0
X-Mailer: Evolution 2.8.2 
Content-Transfer-Encoding: 7bit
X-Server-Quench: 78f66979-6b4b-11dc-b86a-001185d377ca
X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MOFUSTAAU
	PkFRNXJLN0YASktU QCdXRQsWBxNzXHwW PkpObwVdZVpPXw9u
	UUJLQxxaERtqAB0f BxoXTBtwaAdDZ34+ OU4CVyYgIkR6dkV9
	QU0aFGgPYilnYDYZ Vklffh5SIgcYYx5E PgNiBnsLMHgHZnth
	T1I/ZG9uNjxJNyRY REkRN1sUWk8AAj87 QVgJGjAqHFFNTSg8 Lho9QmMy
X-Authentic-SMTP: 61633235383639.squirrel.dmpriest.net.uk:752/Kp
X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse
X-Virus-Status: No virus detected - but ensure you scan with your own
	anti-virus system!
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200709/21
X-Sequence-Number: 4419

I'd like to reword this line in the Asynch commit docs:

   "when transaction commit begins."

Transaction commit is when the transaction ends, so using the word begin
in that way is confusing.

Index: doc/src/sgml/wal.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/wal.sgml,v
retrieving revision 1.45
diff -c -r1.45 wal.sgml
*** doc/src/sgml/wal.sgml       1 Aug 2007 22:45:07 -0000       1.45
--- doc/src/sgml/wal.sgml       25 Sep 2007 08:01:06 -0000
***************
*** 216,222 ****
     <xref linkend="guc-synchronous-commit">, which can be changed in
any of
     the ways that a configuration parameter can be set.  The mode used
for
     any one transaction depends on the value of
!    <varname>synchronous_commit</varname> when transaction commit
begins.
    </para>

    <para>
--- 216,223 ----
     <xref linkend="guc-synchronous-commit">, which can be changed in
any of
     the ways that a configuration parameter can be set.  The mode used
for
     any one transaction depends on the value of
!    <varname>synchronous_commit</varname> at the time of transaction
commit,
!    so <command>SET LOCAL</> can also be used.
    </para>

    <para>


-- 
  Simon Riggs
  2ndQuadrant  http://www.2ndQuadrant.com