From: =?UTF-8?Q?J=c3=bcrgen_Purtz?= <juergen@purtz.de>
Subject: Re: Add A Glossary
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Roger Harkavy <rogerharkavy@gmail.com>, pgsql-hackers@postgresql.org,
 Fabien COELHO <coelho@cri.ensmp.fr>, Michael Paquier <michael@paquier.xyz>
References: 
 <CADkLM=fwtE-TCU7sRnvaE74z12kOp_A+CdUwMr7aZt39pXbh6A@mail.gmail.com>
 <20200320001122.GA19602@alvherre.pgsql>
 <20200320195841.GA13662@telsasoft.com>
 <64b49f34-eaf6-6de2-e951-0eb8d4afabc2@purtz.de>
 <20200327201200.GV20103@telsasoft.com>
 <ff6028d0-ff04-6d11-c41b-2bddb41777d0@purtz.de>
 <CADkLM=eHCVmL8JnmaW2h+XXLRpKzkLrq6WXMbKB7giJCuS=jXA@mail.gmail.com>
 <84cfa166-89d2-db0c-f5bd-421ca2b2f590@purtz.de>
 <20200331175845.GF14618@telsasoft.com>
Message-ID: <11c93b2a-2445-148b-30a9-35fb9eee82d7@purtz.de>
Date: Wed, 1 Apr 2020 09:34:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200331175845.GF14618@telsasoft.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>>         Record</glossterm>s to the file system and creates a special
>>         checkpoint record. This process is initiated when predefined
>>         conditions are met, such as a specified amount of time has passed, or
>> -      a certain volume of records have been collected.
>> +      a certain volume of records has been collected.
> I think you're correct in that "volume" is singular.  But I think "collected"
> is the wrong world.  I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written", 
the WAL records will be written when the Checkpointer is running, not 
before. So:

  "a certain volume of <glossterm>WAL records<glossterm> has been 
collected."


Every thing else is ok for me.

Kind regards, Jürgen