Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id EEFD964FCD3 for ; Sun, 7 Sep 2008 08:14:26 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 34159-04 for ; Sun, 7 Sep 2008 08:14:23 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from outmail136063.authsmtp.net (outmail136063.authsmtp.net [62.13.136.63]) by postgresql.org (Postfix) with ESMTP id 6F17764FCC2 for ; Sun, 7 Sep 2008 08:14:22 -0300 (ADT) Received: from punt9.authsmtp.com (punt9.authsmtp.com [62.13.128.70]) by punt2.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m87BELpO042138 for ; Sun, 7 Sep 2008 12:14:21 +0100 (BST) Received: from mail-c187.authsmtp.com (mail-c187.authsmtp.com [62.13.128.33]) by punt9.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m87BEKpb071172; Sun, 7 Sep 2008 12:14:20 +0100 (BST) Received: from [192.168.0.2] (85-211-229-97.dyn.gotadsl.co.uk [85.211.229.97]) (authenticated bits=0) by mail.authsmtp.com (8.14.2/8.14.2/Kp) with ESMTP id m87BEJ51020349; Sun, 7 Sep 2008 12:14:19 +0100 (BST) Subject: Re: Incorrect description of xmax and xip in functions docs From: Simon Riggs To: Bruce Momjian Cc: pgsql-docs In-Reply-To: <200809070131.m871V2j00862@momjian.us> References: <200809070131.m871V2j00862@momjian.us> Content-Type: text/plain Date: Sun, 07 Sep 2008 12:14:23 +0100 Message-Id: <1220786063.3913.8.camel@ebony.2ndQuadrant> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit X-Server-Quench: 1e0108c7-7cce-11dd-8155-001185d377ca X-AuthRoute: OCdxZQATClZOTQEd DAteCiNZVAwpPBRK HVkIKg5MJUcNSQVJ NksadBtFaAJbflxB HGQLW1xEUV97WGd/ agMfZQBDYEtPQQdo WVZARU1QEQdtHhxP WxYZIGwIcgRGen5z YU8sX3FeWAp7IEZ8 QkYHEnABNjQ1dWEe BBRFfwJRdR5Kfh5E YlUrV3QKMjRJBC9q VzwfGBsKCH1+Li9S WBsAJk5aTUsQFSQ9 XwwDGjNnGkNNVyA6 P1QvLFJUDEcJekQ0 eVU8X1kEMhgUEUVS GEpWaF9z X-Authentic-SMTP: 61633235383639.squirrel.dmpriest.net.uk:1186/Kp X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/5 X-Sequence-Number: 4966 On Sat, 2008-09-06 at 21:31 -0400, Bruce Momjian wrote: > Applied, and attached. Thanks. > > And for txid_visible_in_snapshot() comment added: > > "Function should not be used with subtransaction xids. It is possible > > that this function will return a true result for a subtransaction xid > > that was actually still in progress at the time of the snapshot". > > I think the cleaner solution is to throw an appropriate error if a > subtransaction xid is used, rather than adding documentation. Or maybe check subtrans for it, as it really should be doing. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support