Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL
	LOCATION
From: Simon Riggs <simon@2ndQuadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Fujii Masao <masao.fujii@gmail.com>, Bruce Momjian <bruce@momjian.us>,
	Randy Isbell <jisbell@cisco.com>, pgsql-bugs@postgresql.org
In-Reply-To: <6718.1232036141@sss.pgh.pa.us>
References: <200901150150.n0F1oV113850@momjian.us>
	<496F2795.70105@enterprisedb.com>
	<3f0b79eb0901150615g133f845erc39faf19793d5977@mail.gmail.com>
	<496F5502.4020907@enterprisedb.com>  <6718.1232036141@sss.pgh.pa.us>
Content-Type: text/plain
Date: Thu, 15 Jan 2009 17:33:44 +0000
Message-Id: <1232040824.31921.76.camel@ebony.2ndQuadrant>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Thu, 2009-01-15 at 11:15 -0500, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
> > Fujii Masao wrote:
> >> Only a part of backup
> >> history file (the file name including stop wal location) is changed.
> >> Currently, the file name is wrong if stop wal location indicates a boundary
> >> byte. This would confuse the user, I think.
> 
> > Should we change it in HEAD? I'm leaning towards no, on the grounds that 
> > tools/people would then have to know the version it's dealing with to 
> > interpret the value correctly, and because pg_stop_backup() now waits 
> > for the last xlog file to be archived before returning, there's little 
> > need to look at that file.
> 
> I agree.  It might have been better to define it the other way
> originally, but the risks of changing it now outweigh any likely
> benefit.

Agreed. It's too confusing the other way.

The manual entry wasn't changed from my original submission
unfortunately.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support