Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 805591337B67 for ; Sat, 16 Oct 2010 01:30:39 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 55376-03 for ; Sat, 16 Oct 2010 04:30:32 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from spinlock.commandprompt.com (host-215.commandprompt.net [207.173.203.215]) by mail.postgresql.org (Postfix) with ESMTP id 3405C1337B61 for ; Sat, 16 Oct 2010 01:30:32 -0300 (ADT) Received: from localhost (localhost [127.0.0.1]) by spinlock.commandprompt.com (Postfix) with ESMTP id 4B96734801A; Fri, 15 Oct 2010 21:30:24 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at commandprompt.com Received: from spinlock.commandprompt.com ([127.0.0.1]) by localhost (spinlock.commandprompt.com.commandprompt.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jGVdk2Jn7wy; Fri, 15 Oct 2010 21:30:18 -0700 (PDT) Received: from perhan.alvh.no-ip.org (200-85-213-6.bk4-dsl.surnet.cl [200.85.213.6]) by spinlock.commandprompt.com (Postfix) with ESMTPSA id 7D3E2348019; Fri, 15 Oct 2010 21:30:18 -0700 (PDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id AF5206E474; Sat, 16 Oct 2010 01:30:14 -0300 (CLST) Content-Type: text/plain; charset=UTF-8 Cc: pgsql-docs Subject: Re: description of translate() From: Alvaro Herrera To: Josh Kupershmidt In-reply-to: References: Date: Sat, 16 Oct 2010 01:30:14 -0300 Message-Id: <1287203328-sup-173@alvh.no-ip.org> User-Agent: Sup/git Content-Transfer-Encoding: 8bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.324 tagged_above=-5 required=5 tests=BAYES_00=-1.9, RCVD_IN_NJABL_PROXY=2.224 X-Spam-Level: X-Archive-Number: 201010/44 X-Sequence-Number: 6185 Excerpts from Josh Kupershmidt's message of mié oct 13 21:50:40 -0300 2010: > This description leaves off the other half of translate()'s > capability, namely stripping unwanted characters entirely. The comment > for the translate() in oracle_compat.c is helpful here, saying: Agreed. I applied your patch and also touched the example slightly to illustrate this. I didn't backpatch this; probably not worth the trouble. Thanks. -- Álvaro Herrera The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support