pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedRe: misspellings & typofixes
7+ messages / 2 participants
[nested] [flat]
* Re: misspellings & typofixes
@ 2012-04-21 17:49 Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Josh Kupershmidt @ 2012-04-21 17:49 UTC (permalink / raw)
To: pgsql-docs
On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> Attached is a big patch fixing obvious typos/misspellings.
And here's a separate patch with a few more I turned up.
Josh
Attachments:
typos.round2.diff (application/octet-stream, 2.8K) download
diff --git a/contrib/unaccent/unaccent.c b/contrib/unaccent/unaccent.c
new file mode 100644
index a39285e..262d5ec
*** a/contrib/unaccent/unaccent.c
--- b/contrib/unaccent/unaccent.c
*************** unaccent_lexize(PG_FUNCTION_ARGS)
*** 281,287 ****
{
if (!res)
{
! /* allocate res only it it's needed */
res = palloc0(sizeof(TSLexeme) * 2);
res->lexeme = trgchar = palloc(len * pg_database_encoding_max_length() + 1 /* \0 */ );
res->flags = TSL_FILTER;
--- 281,287 ----
{
if (!res)
{
! /* allocate res only if it's needed */
res = palloc0(sizeof(TSLexeme) * 2);
res->lexeme = trgchar = palloc(len * pg_database_encoding_max_length() + 1 /* \0 */ );
res->flags = TSL_FILTER;
diff --git a/src/backend/access/transam/README b/src/backend/access/transam/README
new file mode 100644
index de72f71..54d97a5
*** a/src/backend/access/transam/README
--- b/src/backend/access/transam/README
*************** If a subtransaction requires an XID, we
*** 197,203 ****
parent. This maintains the invariant that child transactions have XIDs later
than their parents, which is assumed in a number of places.
! The subsidiary actions of obtaining a lock on the XID and and entering it into
pg_subtrans and PG_PROC are done at the time it is assigned.
A transaction that has no XID still needs to be identified for various
--- 197,203 ----
parent. This maintains the invariant that child transactions have XIDs later
than their parents, which is assumed in a number of places.
! The subsidiary actions of obtaining a lock on the XID and entering it into
pg_subtrans and PG_PROC are done at the time it is assigned.
A transaction that has no XID still needs to be identified for various
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
new file mode 100644
index a481eef..d59ee68
*** a/src/backend/postmaster/postmaster.c
--- b/src/backend/postmaster/postmaster.c
*************** reaper(SIGNAL_ARGS)
*** 2506,2512 ****
* Was it the archiver? If so, just try to start a new one; no need
* to force reset of the rest of the system. (If fail, we'll try
* again in future cycles of the main loop.). Unless we were waiting
! * for it to shut down; don't restart it in that case, and and
* PostmasterStateMachine() will advance to the next shutdown step.
*/
if (pid == PgArchPID)
--- 2506,2512 ----
* Was it the archiver? If so, just try to start a new one; no need
* to force reset of the rest of the system. (If fail, we'll try
* again in future cycles of the main loop.). Unless we were waiting
! * for it to shut down; don't restart it in that case, and
* PostmasterStateMachine() will advance to the next shutdown step.
*/
if (pid == PgArchPID)
* Re: misspellings & typofixes
@ 2012-04-22 16:24 Peter Eisentraut <peter_e@gmx.net>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Eisentraut @ 2012-04-22 16:24 UTC (permalink / raw)
To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs
On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
> On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> > Attached is a big patch fixing obvious typos/misspellings.
>
> And here's a separate patch with a few more I turned up.
Committed.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: misspellings & typofixes
@ 2012-04-23 04:26 Josh Kupershmidt <schmiddy@gmail.com>
parent: Peter Eisentraut <peter_e@gmx.net>
0 siblings, 1 reply; 7+ messages in thread
From: Josh Kupershmidt @ 2012-04-23 04:26 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-docs
On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
>> On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
>> > Attached is a big patch fixing obvious typos/misspellings.
>>
>> And here's a separate patch with a few more I turned up.
>
> Committed.
Thanks! [Just to avoid confusion, the first patch is still unapplied].
Josh
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: misspellings & typofixes
@ 2012-04-23 18:39 Peter Eisentraut <peter_e@gmx.net>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Peter Eisentraut @ 2012-04-23 18:39 UTC (permalink / raw)
To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs
On sön, 2012-04-22 at 21:26 -0700, Josh Kupershmidt wrote:
> On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
> >> On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> >> > Attached is a big patch fixing obvious typos/misspellings.
> >>
> >> And here's a separate patch with a few more I turned up.
> >
> > Committed.
>
> Thanks! [Just to avoid confusion, the first patch is still unapplied].
Uh, just to add to the confusion, I don't see any other similar patch
from you.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: misspellings & typofixes
@ 2012-04-23 20:30 Josh Kupershmidt <schmiddy@gmail.com>
parent: Peter Eisentraut <peter_e@gmx.net>
0 siblings, 1 reply; 7+ messages in thread
From: Josh Kupershmidt @ 2012-04-23 20:30 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-docs
On Mon, Apr 23, 2012 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On sön, 2012-04-22 at 21:26 -0700, Josh Kupershmidt wrote:
>> On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
>> > On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
>> >> On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
>> >> > Attached is a big patch fixing obvious typos/misspellings.
>> >>
>> >> And here's a separate patch with a few more I turned up.
>> >
>> > Committed.
>>
>> Thanks! [Just to avoid confusion, the first patch is still unapplied].
>
> Uh, just to add to the confusion, I don't see any other similar patch
> from you.
Maybe the list ate it because the patch was too big :-(
Below is my original email, and I'll attach a gzip'ed version of the
original patch instead.
Josh
---------- Forwarded message ----------
From: Josh Kupershmidt <schmiddy@gmail.com>
Date: Thu, Apr 12, 2012 at 7:17 PM
Subject: misspellings & typofixes
To: pgsql-docs <pgsql-docs@postgresql.org>
Hi all,
Attached is a big patch fixing obvious typos/misspellings. I'd been
sitting on a few, and also used a script to search out common
errors[1].
While I was mucking around, these two comments caught my eye:
inline patch 1: src/pl/plperl/plperl_helpers.h (+0/-0 lines) download inline-1.patch
*** a/src/pl/plperl/plperl_helpers.h
--- b/src/pl/plperl/plperl_helpers.h
*************** sv2cstr(SV *sv)
*** 62,68 ****
inline patch 2: contrib/pgcrypto/pgp-compress.c (+0/-0 lines) download inline-2.patch
*** a/contrib/pgcrypto/pgp-compress.c
--- b/contrib/pgcrypto/pgp-compress.c
*************** compress_init(PushFilter *next, void *in
*** 105,111 ****
* Re: misspellings & typofixes
@ 2012-05-08 01:29 Josh Kupershmidt <schmiddy@gmail.com>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 7+ messages in thread
From: Josh Kupershmidt @ 2012-05-08 01:29 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-docs
On Mon, Apr 23, 2012 at 8:30 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> Below is my original email, and I'll attach a gzip'ed version of the
> original patch instead.
I see Robert applied the patch (thanks!).
Did anyone else think the two comments I pointed out were in need of
fixing? Possible patch for those attached.
Josh
Attachments:
fix_misleading_comments.diff (application/octet-stream, 1.3K) download
diff --git a/contrib/pgcrypto/pgp-compress.c b/contrib/pgcrypto/pgp-compress.c
new file mode 100644
index 7a9516b..c592453
*** a/contrib/pgcrypto/pgp-compress.c
--- b/contrib/pgcrypto/pgp-compress.c
*************** compress_init(PushFilter *next, void *in
*** 105,111 ****
/* writes compressed data packet */
! /* cant handle zero-len incoming data, but shouldnt */
static int
compress_process(PushFilter *next, void *priv, const uint8 *data, int len)
{
--- 105,111 ----
/* writes compressed data packet */
! /* can handle zero-len incoming data, but shouldn't */
static int
compress_process(PushFilter *next, void *priv, const uint8 *data, int len)
{
diff --git a/src/pl/plperl/plperl_helpers.h b/src/pl/plperl/plperl_helpers.h
new file mode 100644
index 35e1257..2c17790
*** a/src/pl/plperl/plperl_helpers.h
--- b/src/pl/plperl/plperl_helpers.h
*************** sv2cstr(SV *sv)
*** 62,68 ****
(SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
sv = newSVsv(sv);
else
! /* increase the reference count so we cant just SvREFCNT_dec() it when
* we are done */
SvREFCNT_inc(sv);
--- 62,68 ----
(SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
sv = newSVsv(sv);
else
! /* increase the reference count so we can just SvREFCNT_dec() it when
* we are done */
SvREFCNT_inc(sv);
* Re: misspellings & typofixes
@ 2012-05-08 16:36 Peter Eisentraut <peter_e@gmx.net>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2012-05-08 16:36 UTC (permalink / raw)
To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs
On tis, 2012-05-08 at 01:29 +0000, Josh Kupershmidt wrote:
> On Mon, Apr 23, 2012 at 8:30 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
>
> > Below is my original email, and I'll attach a gzip'ed version of the
> > original patch instead.
>
> I see Robert applied the patch (thanks!).
>
> Did anyone else think the two comments I pointed out were in need of
> fixing? Possible patch for those attached.
committed
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2012-05-08 16:36 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2012-04-21 17:49 Re: misspellings & typofixes Josh Kupershmidt <schmiddy@gmail.com>
2012-04-22 16:24 ` Peter Eisentraut <peter_e@gmx.net>
2012-04-23 04:26 ` Josh Kupershmidt <schmiddy@gmail.com>
2012-04-23 18:39 ` Peter Eisentraut <peter_e@gmx.net>
2012-04-23 20:30 ` Josh Kupershmidt <schmiddy@gmail.com>
2012-05-08 01:29 ` Josh Kupershmidt <schmiddy@gmail.com>
2012-05-08 16:36 ` Peter Eisentraut <peter_e@gmx.net>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox