pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedCapitalization of 'TimeZone' GUC
3+ messages / 2 participants
[nested] [flat]
* Capitalization of 'TimeZone' GUC
@ 2012-05-05 00:37 Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Josh Kupershmidt @ 2012-05-05 00:37 UTC (permalink / raw)
To: pgsql-docs
Hi all,
I noticed that the 'TimeZone' GUC is displayed in all-lowercase at:
http://www.postgresql.org/docs/9.1/static/runtime-config-client.html
when it should be camel-cased like 'DateStyle' and 'IntervalStyle'
above it, since that is how the GUC is displayed to users, e.g. as the
column name for 'SHOW timezone;'
Small patch attached.
Josh
Attachments:
timezone_capitalization.diff (text/x-patch, 934B) download
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
new file mode 100644
index e58dc18..1e2c033
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
*************** SET XML OPTION { DOCUMENT | CONTENT };
*** 5152,5160 ****
</varlistentry>
<varlistentry id="guc-timezone" xreflabel="timezone">
! <term><varname>timezone</varname> (<type>string</type>)</term>
<indexterm>
! <primary><varname>timezone</> configuration parameter</primary>
</indexterm>
<indexterm><primary>time zone</></>
<listitem>
--- 5152,5160 ----
</varlistentry>
<varlistentry id="guc-timezone" xreflabel="timezone">
! <term><varname>TimeZone</varname> (<type>string</type>)</term>
<indexterm>
! <primary><varname>TimeZone</> configuration parameter</primary>
</indexterm>
<indexterm><primary>time zone</></>
<listitem>
* Re: Capitalization of 'TimeZone' GUC
@ 2012-05-10 18:00 Peter Eisentraut <peter_e@gmx.net>
parent: Josh Kupershmidt <schmiddy@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Peter Eisentraut @ 2012-05-10 18:00 UTC (permalink / raw)
To: Josh Kupershmidt <schmiddy@gmail.com>; +Cc: pgsql-docs
On fre, 2012-05-04 at 17:37 -0700, Josh Kupershmidt wrote:
> Hi all,
>
> I noticed that the 'TimeZone' GUC is displayed in all-lowercase at:
> http://www.postgresql.org/docs/9.1/static/runtime-config-client.html
>
> when it should be camel-cased like 'DateStyle' and 'IntervalStyle'
> above it, since that is how the GUC is displayed to users, e.g. as the
> column name for 'SHOW timezone;'
Fixed that (you forgot to change xreflabel). There are many other
places where this is "misspelled", but there are also many other places
where DateStyle is capitalized inconsistently. It's perhaps not worth
fixing all that.
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Capitalization of 'TimeZone' GUC
@ 2012-05-11 22:23 Josh Kupershmidt <schmiddy@gmail.com>
parent: Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 3+ messages in thread
From: Josh Kupershmidt @ 2012-05-11 22:23 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-docs
On Thu, May 10, 2012 at 11:00 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On fre, 2012-05-04 at 17:37 -0700, Josh Kupershmidt wrote:
>> Hi all,
>>
>> I noticed that the 'TimeZone' GUC is displayed in all-lowercase at:
>> http://www.postgresql.org/docs/9.1/static/runtime-config-client.html
>>
>> when it should be camel-cased like 'DateStyle' and 'IntervalStyle'
>> above it, since that is how the GUC is displayed to users, e.g. as the
>> column name for 'SHOW timezone;'
>
> Fixed that (you forgot to change xreflabel). There are many other
> places where this is "misspelled", but there are also many other places
> where DateStyle is capitalized inconsistently. It's perhaps not worth
> fixing all that.
Thanks. TimeZone was the only mis-capitalized GUC <varname> which I
noticed while going through config.sgml, which is why I picked on it,
but I could easily have missed a few.
Josh
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2012-05-11 22:23 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2012-05-05 00:37 Capitalization of 'TimeZone' GUC Josh Kupershmidt <schmiddy@gmail.com>
2012-05-10 18:00 ` Peter Eisentraut <peter_e@gmx.net>
2012-05-11 22:23 ` Josh Kupershmidt <schmiddy@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox