Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVhdE-0008Fz-V7 for pgsql-docs@arkaria.postgresql.org; Fri, 15 Nov 2019 19:51:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iVhdD-0001gm-7H for pgsql-docs@arkaria.postgresql.org; Fri, 15 Nov 2019 19:51:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVhdC-0001gf-WB for pgsql-docs@lists.postgresql.org; Fri, 15 Nov 2019 19:51:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iVhdA-0005Br-F0 for pgsql-docs@lists.postgresql.org; Fri, 15 Nov 2019 19:51:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xAFJofGh013439; Fri, 15 Nov 2019 14:50:41 -0500 From: Tom Lane To: "David G. Johnston" cc: joe@nahmias.net, pgsql-docs@lists.postgresql.org Subject: Re: no mention of GRANT USAGE in postgres_fdw docs In-reply-to: References: <157377058468.1209.1912214624357780577@wrigleys.postgresql.org> <11507.1573844676@sss.pgh.pa.us> Comments: In-reply-to "David G. Johnston" message dated "Fri, 15 Nov 2019 12:42:16 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <13437.1573847441.1@sss.pgh.pa.us> Date: Fri, 15 Nov 2019 14:50:41 -0500 Message-ID: <13438.1573847441@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk "David G. Johnston" writes: > On Fri, Nov 15, 2019 at 12:05 PM Tom Lane wrote: >> I'm not clear why we should duplicate that information here, especially >> when we're not duplicating any of the other essential information about >> how to use IMPORT FOREIGN SCHEMA. Nor does this summary mention the >> privilege requirements for any of the other commands it suggests using. > The overview page says: "Create a user mapping, using CREATE USER MAPPING, > for each database user you want to allow to access each foreign server." > It seems reasonable to add that you need to grant those same users the > USAGE privilege on each foreign server as well. But you don't necessarily, do you? I think you only need that to create a foreign table referencing the server, not to use one that somebody else created. (Too lazy to check the details right now.) Anyway, my point is that details like this belong in the respective command man pages. If we were to copy them into postgres-fdw's summary, we'd never remember to update that if they changed. regards, tom lane