Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125])
	by mail.postgresql.org (Postfix) with ESMTP id 323CA1E1C8
	for <pgsql-docs@postgresql.org>; Sat, 26 Nov 2011 13:17:41 -0400 (AST)
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtp (Exim 4.72)
	(envelope-from <tgl@sss.pgh.pa.us>) id 1RULsi-0003PT-8h
	for pgsql-docs@postgresql.org; Sat, 26 Nov 2011 17:17:40 +0000
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id pAQHHRdK013977;
	Sat, 26 Nov 2011 12:17:27 -0500 (EST)
To: Daniele Varrazzo <daniele.varrazzo@gmail.com>
cc: pgsql-docs@postgresql.org
Subject: Re: Wrong advisory locks docs in pg_locks 
In-reply-to: 
 <CA+mi_8Z67=OTJrNMxzKvtsTRcKXmrN50GUjtnLvkZ3=d2-ky1g@mail.gmail.com>
References: 
 <CA+mi_8Z67=OTJrNMxzKvtsTRcKXmrN50GUjtnLvkZ3=d2-ky1g@mail.gmail.com>
Comments: In-reply-to Daniele Varrazzo <daniele.varrazzo@gmail.com>
	message dated "Fri, 25 Nov 2011 13:54:27 +0000"
Date: Sat, 26 Nov 2011 12:17:27 -0500
Message-ID: <13976.1322327847@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Pg-Spam-Score: -3.1 (---)
X-Archive-Number: 201111/27
X-Sequence-Number: 7102

Daniele Varrazzo <daniele.varrazzo@gmail.com> writes:
> documentation about advisory locks in the pg_locks view
> <http://developer.postgresql.org/pgdocs/postgres/view-pg-locks.html>
> is incorrect/incomplete: the space specifier field is objsubid, not
> objid, and there is no information about how the key is stored.

Actually, there is a paragraph further down that correctly explains what
advisory locks look like.  I think the best fix is to remove the
incorrect annotation on objid and leave it at that; shoehorning
additional sentences into table columns that are meant to contain
short phrases is not an improvement.

			regards, tom lane