public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: [email protected] <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: pg_type_d.h location incorrect
Date: Tue, 25 May 2021 23:19:40 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS0PR01MB6113637F7DBED4565902A460FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<OS0PR01MB6113637F7DBED4565902A460FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>

"[email protected]" <[email protected]> writes:
> Attached a patch to fix the incorrect location description of pg_type_d.h posted by myself at [1].

I don't particularly find that to be an improvement.  In the first
place, it's somewhere between unhelpful and flat out wrong for
people on Windows, where the backtick notation doesn't work (AFAIK).
In the second, it will distract almost every user, who will need
to stop for a second or two to think about what context they would
use backticks in, and about what pg_config is, and whether the right
pg_config is even in their $PATH, and about why --pkgincludedir is
the right switch.  If they don't already have a bunch of those facts
swapped in, it will take a lot longer than a second or two to figure
out what is meant here.  That seems completely out of proportion to
the value of having this passing mention be pedantically correct.

Maybe it'd be better to just refer to "catalog/pg_type_d.h", which
is the approved way to spell it in #include directives, and leave
it to users who actually care to figure out where that is in their
filesystems.  I see from the git history that we've tried a few
different variations on trying to be more precise than that, and
they've apparently all been failures.

			regards, tom lane

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_type_d.h location incorrect
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox