pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Numeric documentation paragraph reverse argument order.
3+ messages / 3 participants
[nested] [flat]

* Numeric documentation paragraph reverse argument order.
@ 2018-06-22 13:54 PG Doc comments form <noreply@postgresql.org>
  2018-06-24 22:08 ` Re: Numeric documentation paragraph reverse argument order. Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 3+ messages in thread

From: PG Doc comments form @ 2018-06-22 13:54 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org; +Cc: claytonjsalem@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/datatype-numeric.html
Description:

This is not a correction, but a clarification. In the paragraph describing
the Numeric type,
https://www.postgresql.org/docs/10/static/datatype-numeric.html#DATATYPE-NUMERIC-DECIMAL
the description of the arguments is reversed from the order of the
arguments, i.e. scale before numeric, while the argument is numeric before
scale. My suggestion is to change the following paragraph:

> We use the following terms below: The scale of a numeric is the count of
decimal digits in the fractional part, to the right of the decimal point.
The precision of a numeric is the total count of significant digits in the
whole number, that is, the number of digits to both sides of the decimal
point. So the number 23.5141 has a precision of 6 and a scale of 4. Integers
can be considered to have a scale of zero.

to:

> We use the following terms below: The precision of a numeric is the total
count of significant digits in the whole number, that is, the number of
digits to both sides of the decimal point. The scale of a numeric is the
count of decimal digits in the fractional part, to the right of the decimal
point. So the number 23.5141 has a precision of 6 and a scale of 4. Integers
can be considered to have a scale of zero.

That way the order in the paragraph (precision, scale), matches the argument
order `NUMERIC(precision, scale)`


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Numeric documentation paragraph reverse argument order.
  2018-06-22 13:54 Numeric documentation paragraph reverse argument order. PG Doc comments form <noreply@postgresql.org>
@ 2018-06-24 22:08 ` Bruce Momjian <bruce@momjian.us>
  2018-06-24 22:08   ` Re: Numeric documentation paragraph reverse argument order. Clayton Salem <claytonjsalem@gmail.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Bruce Momjian @ 2018-06-24 22:08 UTC (permalink / raw)
  To: claytonjsalem@gmail.com; pgsql-docs@lists.postgresql.org

On Fri, Jun 22, 2018 at 01:54:26PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/10/static/datatype-numeric.html
> Description:
> 
> This is not a correction, but a clarification. In the paragraph describing
> the Numeric type,
> https://www.postgresql.org/docs/10/static/datatype-numeric.html#DATATYPE-NUMERIC-DECIMAL
> the description of the arguments is reversed from the order of the
> arguments, i.e. scale before numeric, while the argument is numeric before
> scale. My suggestion is to change the following paragraph:
> 
> > We use the following terms below: The scale of a numeric is the count of
> decimal digits in the fractional part, to the right of the decimal point.
> The precision of a numeric is the total count of significant digits in the
> whole number, that is, the number of digits to both sides of the decimal
> point. So the number 23.5141 has a precision of 6 and a scale of 4. Integers
> can be considered to have a scale of zero.
> 
> to:
> 
> > We use the following terms below: The precision of a numeric is the total
> count of significant digits in the whole number, that is, the number of
> digits to both sides of the decimal point. The scale of a numeric is the
> count of decimal digits in the fractional part, to the right of the decimal
> point. So the number 23.5141 has a precision of 6 and a scale of 4. Integers
> can be considered to have a scale of zero.
> 
> That way the order in the paragraph (precision, scale), matches the argument
> order `NUMERIC(precision, scale)`

Now that is an excellent suggestion.  Change applied back through 9.3.
Thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +




^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Numeric documentation paragraph reverse argument order.
  2018-06-22 13:54 Numeric documentation paragraph reverse argument order. PG Doc comments form <noreply@postgresql.org>
  2018-06-24 22:08 ` Re: Numeric documentation paragraph reverse argument order. Bruce Momjian <bruce@momjian.us>
@ 2018-06-24 22:08   ` Clayton Salem <claytonjsalem@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Clayton Salem @ 2018-06-24 22:08 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-docs@lists.postgresql.org

Thank you!


On Sun, Jun 24, 2018 at 6:08 PM Bruce Momjian <bruce@momjian.us> wrote:

> On Fri, Jun 22, 2018 at 01:54:26PM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/10/static/datatype-numeric.html
> > Description:
> >
> > This is not a correction, but a clarification. In the paragraph
> describing
> > the Numeric type,
> >
> https://www.postgresql.org/docs/10/static/datatype-numeric.html#DATATYPE-NUMERIC-DECIMAL
> > the description of the arguments is reversed from the order of the
> > arguments, i.e. scale before numeric, while the argument is numeric
> before
> > scale. My suggestion is to change the following paragraph:
> >
> > > We use the following terms below: The scale of a numeric is the count
> of
> > decimal digits in the fractional part, to the right of the decimal point.
> > The precision of a numeric is the total count of significant digits in
> the
> > whole number, that is, the number of digits to both sides of the decimal
> > point. So the number 23.5141 has a precision of 6 and a scale of 4.
> Integers
> > can be considered to have a scale of zero.
> >
> > to:
> >
> > > We use the following terms below: The precision of a numeric is the
> total
> > count of significant digits in the whole number, that is, the number of
> > digits to both sides of the decimal point. The scale of a numeric is the
> > count of decimal digits in the fractional part, to the right of the
> decimal
> > point. So the number 23.5141 has a precision of 6 and a scale of 4.
> Integers
> > can be considered to have a scale of zero.
> >
> > That way the order in the paragraph (precision, scale), matches the
> argument
> > order `NUMERIC(precision, scale)`
>
> Now that is an excellent suggestion.  Change applied back through 9.3.
> Thanks.
>
> --
>   Bruce Momjian  <bruce@momjian.us>        http://momjian.us
>   EnterpriseDB                             http://enterprisedb.com
>
> + As you are, so once was I.  As I am, so you will be. +
> +                      Ancient Roman grave inscription +
>
-- 
═════════
Clayton Salem
413-768-8522
═════════

^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2018-06-24 22:08 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-22 13:54 Numeric documentation paragraph reverse argument order. PG Doc comments form <noreply@postgresql.org>
2018-06-24 22:08 ` Bruce Momjian <bruce@momjian.us>
2018-06-24 22:08   ` Clayton Salem <claytonjsalem@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox