From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: jordan@jwillikers.com, pgsql-docs@lists.postgresql.org
Subject: Re: systemd service start - disable timeout with "infinity"
In-reply-to: <20220320193629.GW28503@telsasoft.com>
References: <164770078557.670.5467111518383664377@wrigleys.postgresql.org>
 <1445301.1647792679@sss.pgh.pa.us> <20220320193629.GW28503@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Sun, 20 Mar 2022 14:36:29 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1569337.1647805509.1@sss.pgh.pa.us>
Date: Sun, 20 Mar 2022 15:45:09 -0400
Message-ID: <1569338.1647805509@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1569338.1647805509%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Sun, Mar 20, 2022 at 12:11:19PM -0400, Tom Lane wrote:
>> Hmm ... maybe zero works too, or worked when this was written?
>> But you're right that "infinity" is now the documented way
>> to do it.  Will fix, thanks for the report.

> +# 0 is the same as infinity, but "infinity" needs systemd 229

Ah, thanks for the data point.  229 is far enough back that
I'm not too troubled about that; besides, since this is just
a documentation example, clarity is more important.

BTW, what I read in the systemd docs is that TimeoutSec is
a shorthand for setting both TimeoutStartSec and TimeoutStopSec,
so the code in our RPMs looks a bit dubious now:

 # Do not set any timeout value, so that systemd will not kill postmaster
 # during crash recovery.
 TimeoutSec=0
 
+# 0 is the same as infinity, but "infinity" needs systemd 229
+TimeoutStartSec=0
+
+TimeoutStopSec=1h
+
 [Install]

This is making assumptions about what order the values are applied
in, plus the initial comment is no longer very accurate.

			regards, tom lane