public inbox for [email protected]  
help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: add argument type to postgres_fdw docs
Date: Wed, 16 Jun 2021 13:24:49 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYAPR01MB2896DEB25C3B0D57F6139768C40F9@TYAPR01MB2896.jpnprd01.prod.outlook.com>
References: <TYAPR01MB2896DEB25C3B0D57F6139768C40F9@TYAPR01MB2896.jpnprd01.prod.outlook.com>



On 2021/06/16 12:39, [email protected] wrote:
> Hi,
> 
> I add argument type to postgres-fdw parameters in postgres-fdw.sgml.
> I think this change is kind. Do you think?

I think this change would improve the postgres_fdw docs.

-     <term><literal>extensions</literal></term>
+     <term><literal>extensions</literal> (<type>enum</type>)</term>

Since each value in "extensions" parameter is not limitted like
shared_preload_libraries, its type should be "string"?

-     <term><literal>fdw_startup_cost</literal></term>
+     <term><literal>fdw_startup_cost</literal> (<type>double precision</type>)</term>
-     <term><literal>fdw_tuple_cost</literal></term>
+     <term><literal>fdw_tuple_cost</literal> (<type>double precision</type>)</term>

Since "floating point" is used for GUC docs, "floating point" should be
used for the sake of consistenty, instead?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: add argument type to postgres_fdw docs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox