pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feed35.9.2. Base Types in C-Language Functions
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2020-08-31 9524fa1aa5 2bf1bec585 eb7f602478 511d51acb3 102aa4a355 6d33681f57 bef7b917a7 docs: in mapping SQL to C data types, timestamp isn't a pointer
* 35.9.2. Base Types in C-Language Functions
@ 2020-08-26 13:59 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2020-08-26 13:59 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: ajulien@shaktiware.fr
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/12/xfunc-c.html
Description:
In "Table 35-1. Equivalent C Types for Built-in SQL Types", when SQL type is
"timestamp", the C type is reported to be "Timestamp * ", whereas it is
actually "Timestamp". I experienced it in version 9.3 but I guess it is also
the case in current version.
Best regards
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: 35.9.2. Base Types in C-Language Functions
@ 2020-08-26 23:09 Bruce Momjian <bruce@momjian.us>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Momjian @ 2020-08-26 23:09 UTC (permalink / raw)
To: ajulien@shaktiware.fr; pgsql-docs@lists.postgresql.org
On Wed, Aug 26, 2020 at 01:59:42PM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/12/xfunc-c.html
> Description:
>
> In "Table 35-1. Equivalent C Types for Built-in SQL Types", when SQL type is
> "timestamp", the C type is reported to be "Timestamp * ", whereas it is
> actually "Timestamp". I experienced it in version 9.3 but I guess it is also
> the case in current version.
Ah, yes, you are right --- Timestamp is an int64. I will fix that with
the attatched patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:
timestamp.diff (text/x-diff, 493B) download
diff --git a/doc/src/sgml/xfunc.sgml b/doc/src/sgml/xfunc.sgml
index 6de464c654..11addb3e27 100644
--- a/doc/src/sgml/xfunc.sgml
+++ b/doc/src/sgml/xfunc.sgml
@@ -2223,7 +2223,7 @@ memcpy(destination->data, buffer, 40);
</row>
<row>
<entry><type>timestamp</type></entry>
- <entry><type>Timestamp*</type></entry>
+ <entry><type>Timestamp</type></entry>
<entry><filename>datatype/timestamp.h</filename></entry>
</row>
<row>
* Re: 35.9.2. Base Types in C-Language Functions
@ 2020-08-31 21:06 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Momjian @ 2020-08-31 21:06 UTC (permalink / raw)
To: ajulien@shaktiware.fr; pgsql-docs@lists.postgresql.org
On Wed, Aug 26, 2020 at 07:09:04PM -0400, Bruce Momjian wrote:
> On Wed, Aug 26, 2020 at 01:59:42PM +0000, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/12/xfunc-c.html
> > Description:
> >
> > In "Table 35-1. Equivalent C Types for Built-in SQL Types", when SQL type is
> > "timestamp", the C type is reported to be "Timestamp * ", whereas it is
> > actually "Timestamp". I experienced it in version 9.3 but I guess it is also
> > the case in current version.
>
> Ah, yes, you are right --- Timestamp is an int64. I will fix that with
> the attatched patch.
Patch applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-08-31 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 13:59 35.9.2. Base Types in C-Language Functions PG Doc comments form <noreply@postgresql.org>
2020-08-26 23:09 ` Bruce Momjian <bruce@momjian.us>
2020-08-31 21:06 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox