pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedIncorrect source directory in build instructions and build scripts
3+ messages / 3 participants
[nested] [flat]
* Incorrect source directory in build instructions and build scripts
@ 2021-12-10 18:13 PG Doc comments form <noreply@postgresql.org>
2021-12-11 19:20 ` Re: Incorrect source directory in build instructions and build scripts David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: PG Doc comments form @ 2021-12-10 18:13 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: ckline@onezero.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/14/install-windows-full.html
Description:
I recently downloaded the source for PG 14, and attempted to build for
windows using the instructions on this page:
https://www.postgresql.org/docs/current/install-windows-full.html
It appears that both the documentation _and_ the build scripts (e.g.
source/tools/msvc/build.pl) assume the root directory of the installation is
'src' when in fact it is 'source'. This prevents the build scripts from
working (and the documentation is wrong).
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Incorrect source directory in build instructions and build scripts
2021-12-10 18:13 Incorrect source directory in build instructions and build scripts PG Doc comments form <noreply@postgresql.org>
@ 2021-12-11 19:20 ` David G. Johnston <david.g.johnston@gmail.com>
2021-12-12 20:24 ` Re: Incorrect source directory in build instructions and build scripts Chris Kline <ckline@onezero.com>
0 siblings, 1 reply; 3+ messages in thread
From: David G. Johnston @ 2021-12-11 19:20 UTC (permalink / raw)
To: ckline@onezero.com <ckline@onezero.com>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Friday, December 10, 2021, PG Doc comments form <noreply@postgresql.org>
wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/14/install-windows-full.html
> Description:
>
> I recently downloaded the source for PG 14
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Incorrect source directory in build instructions and build scripts
2021-12-10 18:13 Incorrect source directory in build instructions and build scripts PG Doc comments form <noreply@postgresql.org>
2021-12-11 19:20 ` Re: Incorrect source directory in build instructions and build scripts David G. Johnston <david.g.johnston@gmail.com>
@ 2021-12-12 20:24 ` Chris Kline <ckline@onezero.com>
0 siblings, 0 replies; 3+ messages in thread
From: Chris Kline @ 2021-12-12 20:24 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Hi David,
It turns out I had pulled the distribution from
https://www.postgresql.org/ftp/source/v14.0/ and extracted its src/
directory into our repo's structure, which was rooted at /source. I failed
to notice the difference at the time I was having the issues.
My apologies for wasting your time.
-chris
On Sat, Dec 11, 2021 at 2:20 PM David G. Johnston <
david.g.johnston@gmail.com> wrote:
> On Friday, December 10, 2021, PG Doc comments form <noreply@postgresql.org>
> wrote:
>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/14/install-windows-full.html
>> Description:
>>
>> I recently downloaded the source for PG 14
>
>
>>
> From where?
>
>
>>
>> assume the root directory of the installation is
>> 'src' when in fact it is 'source'.
>>
>
> A quick look at the git repo would indicate you are incorrect (or at least
> that the docs are correct in at least the case of checking out the source
> from the official git repo).
>
> https://github.com/postgres/postgres
>
> David J.
>
>
--
--
This email message, including any attachments, is for the sole use of the
individual or entity to whom they are addressed, and may contain
confidential information. If you are not an addressee or otherwise
authorized to receive this message, you should not use, copy, disclose or
take any action based on this e-mail or any information contained in the
message. If you have received this material in error, please advise the
sender immediately by reply e-mail and delete this message. This email by
itself does not constitute an agreement to conduct transactions by
electronic means and does not create any legally binding contract or
enforceable obligation in the absence of a fully signed written contract.
Contract terms contained in this email are subject to approval by an
authorized representative of oneZero and are not binding until an
authorized representative provides approval in writing.
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-12-12 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10 18:13 Incorrect source directory in build instructions and build scripts PG Doc comments form <noreply@postgresql.org>
2021-12-11 19:20 ` David G. Johnston <david.g.johnston@gmail.com>
2021-12-12 20:24 ` Chris Kline <ckline@onezero.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox