public inbox for [email protected]  
help / color / mirror / Atom feed
Mixed field in table 70.3
2+ messages / 2 participants
[nested] [flat]

* Mixed field in table 70.3
@ 2022-04-27 14:45 PG Doc comments form <[email protected]>
  2022-04-27 16:50 ` Re: Mixed field in table 70.3 Tom Lane <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: PG Doc comments form @ 2022-04-27 14:45 UTC (permalink / raw)
  To: [email protected]; +Cc: [email protected]

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/14/storage-page-layout.html
Description:

The 7th line states:
pd_pagesize_version 	uint16 	2 bytes 	Page size and layout version number
information

In fact there are two smallints, so the table should show two attributes:
pd_pagesize 	uint16 	2 bytes 	Page size 
version    	uint16 	2 bytes 	Layout version number information


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Mixed field in table 70.3
  2022-04-27 14:45 Mixed field in table 70.3 PG Doc comments form <[email protected]>
@ 2022-04-27 16:50 ` Tom Lane <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-04-27 16:50 UTC (permalink / raw)
  To: [email protected]; +Cc: [email protected]

PG Doc comments form <[email protected]> writes:
> Page: https://www.postgresql.org/docs/14/storage-page-layout.html

> The 7th line states:
> pd_pagesize_version 	uint16 	2 bytes 	Page size and layout version number
> information

> In fact there are two smallints, so the table should show two attributes:
> pd_pagesize 	uint16 	2 bytes 	Page size 
> version    	uint16 	2 bytes 	Layout version number information

No, I don't think so --- this documentation matches the actual code,
in bufpage.h:

    ...
    LocationIndex pd_lower;        /* offset to start of free space */
    LocationIndex pd_upper;        /* offset to end of free space */
    LocationIndex pd_special;      /* offset to start of special space */
    uint16        pd_pagesize_version;
    TransactionId pd_prune_xid;    /* oldest prunable XID, or zero if none */
    ItemIdData    pd_linp[FLEXIBLE_ARRAY_MEMBER]; /* line pointer array */
    ...

			regards, tom lane






^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-04-27 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 14:45 Mixed field in table 70.3 PG Doc comments form <[email protected]>
2022-04-27 16:50 ` Tom Lane <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox